Bug 222566 - [WinCairo] Building with ENABLE_SERVICE_WORKER=OFF fails
Summary: [WinCairo] Building with ENABLE_SERVICE_WORKER=OFF fails
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Stephan Szabo
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-01 11:05 PST by Stephan Szabo
Modified: 2021-03-01 15:07 PST (History)
1 user (show)

See Also:

Attachments
Patch (1.48 KB, patch)
2021-03-01 11:20 PST, Stephan Szabo 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Szabo 2021-03-01 11:05:28 PST 
It seems after "Make the UserContentController for ServiceWorker pages be non-optional", building without ENABLE_SERVICE_WORKER on WinCairo fails with:

Source\WebKit\UIProcess/WebProcessPool.cpp(1014): error C2039: 'userContentControllerIdentifierForServiceWorkers': is not a member of 'WebKit::WebProcessPool'
Source\WebKit\UIProcess\Notifications\WebNotificationManagerProxy.h(50): note: see declaration of 'WebKit::WebProcessPool'
Source\WebKit\UIProcess/WebProcessPool.cpp(1016): error C2065: 'm_userContentControllerForServiceWorker': undeclared identifier
Source\WebKit\UIProcess/WebProcessPool.cpp(1017): error C2065: 'm_userContentControllerForServiceWorker': undeclared identifier
Source\WebKit\UIProcess/WebProcessPool.cpp(1019): error C2065: 'm_userContentControllerForServiceWorker': undeclared identifier
Comment 1 Stephan Szabo 2021-03-01 11:20:32 PST 
Created attachment 421849 [details]
Patch
Comment 2 EWS 2021-03-01 15:06:16 PST 
Committed r273694: <https://commits.webkit.org/r273694>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 421849 [details].
Comment 3 Radar WebKit Bug Importer 2021-03-01 15:07:19 PST 
<rdar://problem/74893620>