RESOLVED FIXED 222554
[Python-3] Change shebang in runUnittests.py 
https://bugs.webkit.org/show_bug.cgi?id=222554
Summary [Python-3] Change shebang in runUnittests.py
Aakash Jain
Reported 2021-03-01 08:40:52 PST
After recent fixes, Tools/CISupport/runUnittests.py script runs fine with Python 3 for both build.webkit.org and EWS. However, for Python 2, it only supports EWS. We should change shebang in this script to python3 so that someone manually running this script can use it easily for both build.webkit.org and EWS.
Attachments
Patch (847 bytes, patch)
2021-03-01 08:43 PST, Aakash Jain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2021-03-01 08:43:15 PST
Created attachment 421830 [details] Patch
Aakash Jain
Comment 2 2021-03-01 08:44:51 PST
After this change: [CISupport]$./runUnittests.py ews-build ........................................................................................................................................................................................................................................................................................ ---------------------------------------------------------------------- Ran 280 tests in 4.514s OK [CISupport]$./runUnittests.py build-webkit-org ................................................... ---------------------------------------------------------------------- Ran 51 tests in 0.241s OK
Aakash Jain
Comment 3 2021-03-01 08:55:41 PST
This is with latest Buildbot version. [CISupport]$buildbot --version Buildbot version: 2.10.1
Jonathan Bedard
Comment 4 2021-03-01 08:57:15 PST
Comment on attachment 421830 [details] Patch Have we already changed the invocation in Buildbot?
Aakash Jain
Comment 5 2021-03-01 09:04:05 PST
(In reply to Jonathan Bedard from comment #4) > Have we already changed the invocation in Buildbot? build.webkit.org unit-tests already use python3, but EWS unit-tests are using python2 in ews (services bubble). I will change it to python 3 invocation later, when we actually move EWS to python 3. Want to keep running EWS test in EWS in python 2 for now, to make sure we don't break anything for existing instance.
EWS
Comment 6 2021-03-01 09:29:56 PST
Committed r273653: <https://commits.webkit.org/r273653> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421830 [details].
Radar WebKit Bug Importer
Comment 7 2021-03-01 09:30:17 PST
<rdar://problem/74873644>
Note You need to log in before you can comment on or make changes to this bug.