Bug 22254 - Compiler warning for Page.cpp
Summary: Compiler warning for Page.cpp
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Minor
Assignee: Nobody
Depends on:
Reported: 2008-11-13 23:00 PST by Craig Schlenter
Modified: 2008-11-14 09:11 PST (History)
1 user (show)

See Also:

patch to fix compiler warning (1.25 KB, patch)
2008-11-13 23:02 PST, Craig Schlenter
darin: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Craig Schlenter 2008-11-13 23:00:02 PST
I get this when compiling chromium which is running pretty much the latest webkit.

/home/craig/chromium/src/third_party/WebKit/WebCore/page/Page.h: In constructor
'WebCore::Page::Page(WebCore::ChromeClient*, WebCore::ContextMenuClient*,
WebCore::EditorClient*, WebCore::DragClient*, WebCore::InspectorClient*)':
/home/craig/chromium/src/third_party/WebKit/WebCore/page/Page.h:197: warning:
'WebCore::Page::m_inspectorController' will be initialized after
/home/craig/chromium/src/third_party/WebKit/WebCore/page/Page.h:192: warning:  
'WTF::OwnPtr<WebCore::Settings> WebCore::Page::m_settings'
/home/craig/chromium/src/third_party/WebKit/WebCore/page/Page.cpp:105: warning: 
 when initialized here

I have a patch to fix this but at the moment bugzilla isn't showing any "add attachment" options so I'm going to hit commit and hope that I can add the attachment afterwards ...
Comment 1 Craig Schlenter 2008-11-13 23:02:10 PST
Created attachment 25159 [details]
patch to fix compiler warning

uploaded patch .. set review:?
Comment 2 Mark Rowe (bdash) 2008-11-13 23:10:08 PST
Patches against Chromium's version of WebKit should be filed in Chromium's bug tracker.  This patch would *introduce* a warning if applied to tip of tree WebKit.
Comment 3 Craig Schlenter 2008-11-14 03:30:01 PST
Sorry!!! ... I had submitted this for inclusion in chrome and was told to submit webkit patches here but I didn't notice that Page.h is different in WebKit :( I'll try to check things more carefully in future.