Bug 222535 - Support rotated image overlay text for non-rectilinear text quads
Summary: Support rotated image overlay text for non-rectilinear text quads
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-28 20:57 PST by Wenson Hsieh
Modified: 2021-03-01 17:33 PST (History)
11 users (show)

See Also:

Attachments
Patch (17.95 KB, patch)
2021-03-01 13:00 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Add radar link (18.03 KB, patch)
2021-03-01 14:49 PST, Wenson Hsieh 		thorton: review+
Details | Formatted Diff | Diff
Patch for landing (18.00 KB, patch)
2021-03-01 16:10 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2021-02-28 20:57:07 PST 
Support rotated image overlay text for non-rectilinear text quads
Comment 1 Wenson Hsieh 2021-03-01 13:00:33 PST 
Created attachment 421856 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2021-03-01 13:00:55 PST 
<rdar://problem/74886200>
Comment 3 Wenson Hsieh 2021-03-01 14:49:44 PST 
Created attachment 421869 [details]
Add radar link
Comment 4 Tim Horton 2021-03-01 15:39:53 PST 
Comment on attachment 421869 [details]
Add radar link

View in context: https://bugs.webkit.org/attachment.cgi?id=421869&action=review

> Source/WebCore/platform/graphics/GeometryUtilities.h:65
> +struct RotatedRectInfo {

"Info"? This is literally a rotated rectangle :)
Comment 5 Wenson Hsieh 2021-03-01 15:45:59 PST 
Comment on attachment 421869 [details]
Add radar link

View in context: https://bugs.webkit.org/attachment.cgi?id=421869&action=review

>> Source/WebCore/platform/graphics/GeometryUtilities.h:65
>> +struct RotatedRectInfo {
> 
> "Info"? This is literally a rotated rectangle :)

That's a good point — renamed to RotatedRect.
Comment 6 Wenson Hsieh 2021-03-01 16:10:13 PST 
Created attachment 421883 [details]
Patch for landing
Comment 7 EWS 2021-03-01 17:33:03 PST 
Committed r273711: <https://commits.webkit.org/r273711>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 421883 [details].