Bug 222524 - Restoring App Highlight crashes if no range is found.
Summary: Restoring App Highlight crashes if no range is found.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Megan Gardner
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-27 23:23 PST by Megan Gardner
Modified: 2021-03-09 23:57 PST (History)
4 users (show)

See Also:

Attachments
Patch (4.17 KB, patch)
2021-02-27 23:25 PST, Megan Gardner 		no flags Details | Formatted Diff | Diff
Patch for landing (4.09 KB, patch)
2021-03-01 08:47 PST, Megan Gardner 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Megan Gardner 2021-02-27 23:23:05 PST 
Restoring App Highlight crashes if no range is found.
Comment 1 Megan Gardner 2021-02-27 23:25:10 PST 
Created attachment 421766 [details]
Patch
Comment 2 Tim Horton 2021-02-28 01:24:30 PST 
Comment on attachment 421766 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421766&action=review

> Source/WebCore/Modules/highlight/AppHighlightStorage.cpp:243
> +    if (range)

what is the bool return value of this method for? If it’s “did restoration succeed”, perhaps you should return false here?
Comment 3 Megan Gardner 2021-03-01 08:47:10 PST 
Created attachment 421831 [details]
Patch for landing
Comment 4 EWS 2021-03-01 09:36:23 PST 
Committed r273654: <https://commits.webkit.org/r273654>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 421831 [details].
Comment 5 Radar WebKit Bug Importer 2021-03-01 09:37:48 PST 
<rdar://problem/74874015>
Comment 6 Anne 2021-03-09 23:57:29 PST Comment hidden (spam)