Bug 222520 – [LFC][IFC] Every line box must have a root inline box

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[zalan]

let's construct the m_rootInlineBox in LineBox c'tor

[zalan]

Created attachment 421760 [details]
Patch

[zalan]

Created attachment 421761 [details]
Patch

[Sam Weinig]

Comment on attachment 421761 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421761&action=review

> Source/WebCore/ChangeLog:4
> +        [LFC][IFC] Every line box must have a root inline box
> +        https://bugs.webkit.org/show_bug.cgi?id=222520

Should it use a UniqueRef instead of a unique_ptr then, to indicate this via types?

> Source/WebCore/ChangeLog:18
> +        * layout/inlineformatting/InlineFormattingContextGeometry.cpp:
> +        (WebCore::Layout::LineBoxBuilder::build):
> +        (WebCore::Layout::LineBoxBuilder::constructInlineLevelBoxes):
> +        * layout/inlineformatting/InlineLineBox.cpp:
> +        (WebCore::Layout::LineBox::LineBox):
> +        (WebCore::Layout::m_horizontalAlignmentOffset):
> +        (WebCore::Layout::LineBox::logicalRectForTextRun const):
> +        (WebCore::Layout::m_contentLogicalWidth): Deleted.
> +        (WebCore::Layout::LineBox::addRootInlineBox): Deleted.
> +        * layout/inlineformatting/InlineLineBox.h:
> +        (WebCore::Layout::LineBox::InlineLevelBox::createRootInlineBox): Deleted.

This could be fleshed out a bit.

> Source/WebCore/layout/inlineformatting/InlineLineBox.cpp:91
> +    , m_horizontalAlignmentOffset(horizontalAlignmentOffset)
>  {
> +    m_rootInlineBox = makeUnique<LineBox::InlineLevelBox>(rootLayoutBox, horizontalAlignmentOffset.valueOr(InlineLayoutUnit { }), InlineLayoutSize { contentLogicalWidth, { } }, InlineLevelBox::Type::RootInlineBox);

This seems like it should be in the list above.

[zalan]

(In reply to Sam Weinig from comment #3)
> Comment on attachment 421761 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=421761&action=review
> 
> > Source/WebCore/ChangeLog:4
> > +        [LFC][IFC] Every line box must have a root inline box
> > +        https://bugs.webkit.org/show_bug.cgi?id=222520
> 
> Should it use a UniqueRef instead of a unique_ptr then, to indicate this via
> types?
> 
I keep forgetting UniqueRef!!! Thanks.

[zalan]

Created attachment 421765 [details]
Patch

[EWS]

Committed r273636: <https://commits.webkit.org/r273636>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 421765 [details].

[Radar WebKit Bug Importer]

<rdar://problem/74838464>