RESOLVED FIXED 222519
Duplicate headers in WebRTC 
https://bugs.webkit.org/show_bug.cgi?id=222519
Summary Duplicate headers in WebRTC
Alexey Proskuryakov
Reported 2021-02-27 14:35:04 PST
I see these warnings when building WebKit: warning: Skipping duplicate build file in Copy Headers build phase: /Users/ap/Safari/OpenSource/Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_coding/event_wrapper.h (in target 'libwebrtc' from project 'libwebrtc') warning: Skipping duplicate build file in Copy Headers build phase: /Users/ap/Safari/OpenSource/Source/ThirdParty/libwebrtc/Source/webrtc/pc/rtc_stats_collector.h (in target 'libwebrtc' from project 'libwebrtc') warning: Skipping duplicate build file in Copy Headers build phase: /Users/ap/Safari/OpenSource/Source/ThirdParty/libwebrtc/Source/webrtc/pc/rtc_stats_traversal.h (in target 'libwebrtc' from project 'libwebrtc') warning: Skipping duplicate build file in Copy Headers build phase: /Users/ap/Safari/OpenSource/Source/ThirdParty/libwebrtc/Source/webrtc/pc/rtp_media_utils.h (in target 'libwebrtc' from project 'libwebrtc') warning: Skipping duplicate build file in Copy Headers build phase: /Users/ap/Safari/OpenSource/Source/ThirdParty/libwebrtc/Source/webrtc/pc/rtp_transport.h (in target 'libwebrtc' from project 'libwebrtc') warning: Skipping duplicate build file in Copy Headers build phase: /Users/ap/Safari/OpenSource/Source/ThirdParty/libwebrtc/Source/webrtc/pc/rtp_transport_internal.h (in target 'libwebrtc' from project 'libwebrtc') warning: Skipping duplicate build file in Copy Headers build phase: /Users/ap/Safari/OpenSource/Source/ThirdParty/libwebrtc/Source/webrtc/pc/sdp_serializer.h (in target 'libwebrtc' from project 'libwebrtc') warning: Skipping duplicate build file in Copy Headers build phase: /Users/ap/Safari/OpenSource/Source/ThirdParty/libwebrtc/Source/webrtc/pc/srtp_filter.h (in target 'libwebrtc' from project 'libwebrtc') warning: Skipping duplicate build file in Copy Headers build phase: /Users/ap/Safari/OpenSource/Source/ThirdParty/libwebrtc/Source/webrtc/pc/srtp_transport.h (in target 'libwebrtc' from project 'libwebrtc') warning: Skipping duplicate build file in Copy Headers build phase: /Users/ap/Safari/OpenSource/Source/ThirdParty/libwebrtc/Source/webrtc/pc/track_media_info_map.h (in target 'libwebrtc' from project 'libwebrtc') warning: Skipping duplicate build file in Copy Headers build phase: /Users/ap/Safari/OpenSource/Source/ThirdParty/libwebrtc/Source/webrtc/pc/used_ids.h (in target 'libwebrtc' from project 'libwebrtc') warning: Skipping duplicate build file in Copy Headers build phase: /Users/ap/Safari/OpenSource/Source/ThirdParty/libwebrtc/Source/webrtc/pc/video_track.h (in target 'libwebrtc' from project 'libwebrtc') warning: Skipping duplicate build file in Copy Headers build phase: /Users/ap/Safari/OpenSource/Source/ThirdParty/libwebrtc/Source/webrtc/pc/video_track_source.h (in target 'libwebrtc' from project 'libwebrtc')
Attachments
Patch (34.56 KB, patch)
2021-03-09 01:17 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-03-06 14:36:14 PST
<rdar://problem/75137024>
youenn fablet
Comment 2 2021-03-09 01:17:25 PST
Created attachment 422676 [details] Patch
EWS
Comment 3 2021-03-09 09:36:07 PST
Committed r274152: <https://commits.webkit.org/r274152> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422676 [details].
Alexey Proskuryakov
Comment 4 2021-03-09 10:27:44 PST
Comment on attachment 422676 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=422676&action=review > Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj:16841 > 5CDD87091E43BA7500621E92 /* utility.h in Headers */, > 5CDD87DF1E43BC2E00621E92 /* utility.h in Headers */, Is this one problematic too?
Note You need to log in before you can comment on or make changes to this bug.