Bug 222517 - Add alternate, non-named-getter based, implementation of CSSStyleDeclaration back into WebCore
Summary: Add alternate, non-named-getter based, implementation of CSSStyleDeclaration ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks: 217623
  Show dependency tree / graph
 
Reported: 2021-02-27 13:49 PST by Sam Weinig
Modified: 2021-03-01 13:28 PST (History)
16 users (show)

See Also:

Attachments
Patch (53.22 KB, patch)
2021-02-27 14:05 PST, Sam Weinig 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
JSCSSStyleDeclaration.h (if you disable the legacy flag) (4.83 KB, text/x-csrc)
2021-02-27 14:06 PST, Sam Weinig 		no flags Details
JSCSSStyleDeclaration.cpp (if you disable the legacy flag) (3.04 MB, text/x-csrc)
2021-02-27 14:06 PST, Sam Weinig 		no flags Details
Patch (64.37 KB, patch)
2021-02-27 14:11 PST, Sam Weinig 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (64.37 KB, patch)
2021-02-27 14:48 PST, Sam Weinig 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (63.78 KB, patch)
2021-02-27 17:52 PST, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (63.78 KB, patch)
2021-02-28 18:05 PST, Sam Weinig 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2021-02-27 13:49:29 PST 
To aid iteration on a good solution, let's re-land the non-named-getter based, implementation of CSSStyleDeclaration back into WebCore, but behind a compile time flag for now, to avoid the compile  time and binary size regressions (see https://bugs.webkit.org/show_bug.cgi?id=217623).

Once we improve remove the regressions, we can turn it on.
Comment 1 Sam Weinig 2021-02-27 14:05:20 PST Comment hidden (obsolete)
Comment 2 Sam Weinig 2021-02-27 14:06:12 PST 
Created attachment 421756 [details]
JSCSSStyleDeclaration.h (if you disable the legacy flag)
Comment 3 Sam Weinig 2021-02-27 14:06:37 PST 
Created attachment 421757 [details]
JSCSSStyleDeclaration.cpp (if you disable the legacy flag)
Comment 4 Sam Weinig 2021-02-27 14:11:23 PST Comment hidden (obsolete)
Comment 5 Sam Weinig 2021-02-27 14:48:04 PST Comment hidden (obsolete)
Comment 6 Sam Weinig 2021-02-27 17:52:20 PST 
Created attachment 421764 [details]
Patch
Comment 7 Sam Weinig 2021-02-28 14:13:19 PST 
The patch is essentially identical to the previous one which Darin reviewed with the following exceptions:

- Disabled behind a ENABLE flag.
- A little simpler due to no longer having the pixel/pos/css prefixes to deal with.
- Has a bindings test.
- Does not remove old, named getter/setter based code.
Comment 8 Sam Weinig 2021-02-28 17:00:08 PST 
Looks like IDL preprocessing is maybe not a thing on windows :(. We really need to remove that port if no one is going to work on it :(
Comment 9 Sam Weinig 2021-02-28 17:01:17 PST 
Maybe I can work around it by reversing the meaning of the ifdef?
Comment 10 Sam Weinig 2021-02-28 18:05:27 PST 
Created attachment 421786 [details]
Patch
Comment 11 EWS 2021-03-01 13:27:44 PST 
Committed r273688: <https://commits.webkit.org/r273688>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 421786 [details].
Comment 12 Radar WebKit Bug Importer 2021-03-01 13:28:15 PST 
<rdar://problem/74887863>