Bug 222514 – Length blending code should not attempt to blend for progress 0 or 1

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: Animations

[Antoine Quint]

Length blending code should not attempt to blend for progress 0 or 1

[Antoine Quint]

Created attachment 421747 [details]
Patch

[Antti Koivisto]

Comment on attachment 421747 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421747&action=review

> Source/WebCore/platform/Length.cpp:315
> +    if (!progress)
> +        return from;
> +
> +    if (progress == 1)
> +        return to;

Could this be moved to caller/higher level? This is true for all blend operations right?

[Antoine Quint]

(In reply to Antti Koivisto from comment #2)
> Comment on attachment 421747 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=421747&action=review
> 
> > Source/WebCore/platform/Length.cpp:315
> > +    if (!progress)
> > +        return from;
> > +
> > +    if (progress == 1)
> > +        return to;
> 
> Could this be moved to caller/higher level? This is true for all blend
> operations right?

We could move it up to the static Length blendFunc() in CSSPropertyAnimation, but actually doing it at a lower-level means that any caller of blend() will get it for free.

I wish we could generalize this however in the animation wrappers, but it's not obvious to me how this could be done.

[Antoine Quint]

There are fair few progressions more than those I'd recorded but also a few regressions. This is probably an issue similar to that of border-image-slice and its initial value. Will have to look into it and file another patch.

[Antoine Quint]

This will be taken care of as part of bug 222816.

*** This bug has been marked as a duplicate of bug 222816 ***