Bug 222508 – Support fast/canvas/webgl/copyBufferSubData.html, fix bugs in fast/canvas/webgl/getBufferSubData-webgl1.html in Metal ANGLE on Simulator

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Kyle Piddington]

Support  fast/canvas/webgl/copyBufferSubData.html, fix bugs in fast/canvas/webgl/getBufferSubData-webgl1.html in Metal ANGLE on Simulator

[Kyle Piddington]

Created attachment 421731 [details]
Patch

[EWS Watchlist]

Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE

[Dean Jackson]

Comment on attachment 421731 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421731&action=review

> Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/BufferMtl.mm:233
> +    if(result)

Nit: Space before (

> Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/DisplayMtl.mm:331
> +#else //Simulator should be able to support ES3, despite not supporting ios family 4 in it's entirety.

Nit: Space after // and s/it's/its/

I'll fix these when landing.

[Dean Jackson]

Comment on attachment 421731 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421731&action=review

> Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/DisplayMtl.mm:337
>      return gl::Version(2, 0);

I think this statement should go inside the else clause. It wouldn't be hit in the TARGET_OS_SIMULATOR path.

[Dean Jackson]

Committed r273612 (234658@main): <https://commits.webkit.org/234658@main>

[Radar WebKit Bug Importer]

<rdar://problem/74817963>