Bug 222505 - [GPUP] imported/w3c/web-platform-tests/webrtc/RTCRtpSender-replaceTrack.https.html times out with GPU Process enabled
Summary: [GPUP] imported/w3c/web-platform-tests/webrtc/RTCRtpSender-replaceTrack.https...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-26 17:01 PST by Jon Lee
Modified: 2021-03-03 09:11 PST (History)
6 users (show)

See Also:

Attachments
Patch (1.54 KB, patch)
2021-03-01 02:16 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (1.37 KB, patch)
2021-03-03 08:44 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Lee 2021-02-26 17:01:58 PST 
Fix WebRTC layout test failures with GPU Process enabled

latest from gpu-process/TestExpectations:
webrtc/audio-video-element-playing.html [ Failure ]
webrtc/captureCanvas-webrtc-software-h264-baseline.html [ Timeout ]
webrtc/captureCanvas-webrtc-software-h264-high.html [ Timeout ]
webrtc/h264-baseline.html [ Failure ]
webrtc/h264-high.html [ Failure ]
webrtc/video-rotation-no-cvo.html [ Timeout ]
imported/w3c/web-platform-tests/webrtc/RTCRtpSender-replaceTrack.https.html [ Timeout ]
Comment 1 Radar WebKit Bug Importer 2021-02-26 17:02:30 PST 
<rdar://problem/74814573>
Comment 2 youenn fablet 2021-03-01 02:12:56 PST 
From results.webkit.org, they now all pass except imported/w3c/web-platform-tests/webrtc/RTCRtpSender-replaceTrack.https.html which does indeed timeout on the bots, but does not reproduce locally.
Comment 3 youenn fablet 2021-03-01 02:16:35 PST 
Created attachment 421800 [details]
Patch
Comment 4 youenn fablet 2021-03-01 02:19:53 PST 
About imported/w3c/web-platform-tests/webrtc/RTCRtpSender-replaceTrack.https.html:
2021-02-28 20:55:01.056 com.apple.WebKit.GPU.Development[78884:107843434] PT: Got usage property: 1
2021-02-28 20:55:01.056 com.apple.WebKit.GPU.Development[78884:107843434] PT: Usage = 1, use AppleGVA 'avc1' codec
(RTCVideoEncoderH264.mm:730): Compression session created with hw accl enabled
(RTCVideoEncoderH264.mm:497): keyframe requested
(RTCVideoEncoderH264.mm:905): Generated keyframe
(bitrate_prober.cc:134): Probe delay too high (next_ms:1995566429, now_ms: 1995566434)
(bitrate_prober.cc:134): Probe delay too high (next_ms:1995566433, now_ms: 1995566437)
(bitrate_prober.cc:134): Probe delay too high (next_ms:1995566437, now_ms: 1995566443)
(video_receive_stream2.cc:757): No decodable frame in 3000 ms, requesting keyframe.
(rtcp_receiver.cc:315): absl::optional<TimeDelta> webrtc::RTCPReceiver::OnPeriodicRttUpdate(webrtc::Timestamp, bool): Timeout: No increase in RTCP RR extended highest sequence number.
(rtcp_receiver.cc:313): absl::optional<TimeDelta> webrtc::RTCPReceiver::OnPeriodicRttUpdate(webrtc::Timestamp, bool): Timeout: No RTCP RR received.
(RTCVideoEncoderH264.mm:497): keyframe requested
(RTCVideoEncoderH264.mm:905): Generated keyframe
(RTCVideoEncoderH264.mm:891): H264 encode dropped frame.
Comment 5 EWS 2021-03-01 02:44:51 PST 
Committed r273645: <https://commits.webkit.org/r273645>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 421800 [details].
Comment 6 youenn fablet 2021-03-01 02:45:34 PST 
Reopening for imported/w3c/web-platform-tests/webrtc/RTCRtpSender-replaceTrack.https.html
Comment 7 youenn fablet 2021-03-03 08:43:34 PST 
No longer timing out on bots.
Comment 8 youenn fablet 2021-03-03 08:44:40 PST 
Created attachment 422089 [details]
Patch
Comment 9 EWS 2021-03-03 09:11:39 PST 
Committed r273818: <https://commits.webkit.org/r273818>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 422089 [details].