Bug 222497 - Length blending should allow for a ValueRange parameter
Summary: Length blending should allow for a ValueRange parameter
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-26 15:01 PST by Antoine Quint
Modified: 2021-02-26 16:30 PST (History)
4 users (show)

See Also:

Attachments
Patch (5.44 KB, patch)
2021-02-26 15:05 PST, Antoine Quint 		no flags Details | Formatted Diff | Diff
Patch for landing (5.43 KB, patch)
2021-02-26 15:49 PST, Antoine Quint 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2021-02-26 15:01:01 PST 
Length blending should allow for a ValueRange parameter
Comment 1 Antoine Quint 2021-02-26 15:05:52 PST 
Created attachment 421711 [details]
Patch
Comment 2 Dean Jackson 2021-02-26 15:29:44 PST 
Comment on attachment 421711 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421711&action=review

> Source/WebCore/ChangeLog:11
> +        blend() override implementation which would disallow negative values. However, this is something that
> +        should ideally be provided lower down in the blending code in the blend() function provided by the
> +        Length type itself. This will allow us to blend other non-negative length-related types, such as

The sentence starting with However has too many "provided"s.
Comment 3 Antoine Quint 2021-02-26 15:49:32 PST 
Created attachment 421718 [details]
Patch for landing
Comment 4 EWS 2021-02-26 16:29:32 PST 
Committed r273603: <https://commits.webkit.org/r273603>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 421718 [details].
Comment 5 Radar WebKit Bug Importer 2021-02-26 16:30:16 PST 
<rdar://problem/74813273>