Bug 222482 - [git-webkit] Better error message when attempting to convert tag to identifier
Summary: [git-webkit] Better error message when attempting to convert tag to identifier
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-26 10:54 PST by Jonathan Bedard
Modified: 2021-03-02 16:56 PST (History)
2 users (show)

See Also:

Attachments
Patch (2.68 KB, patch)
2021-02-26 10:56 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch for landing (2.62 KB, patch)
2021-03-02 16:10 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2021-02-26 10:54:28 PST 
Aakash pointed to a case where we attempted to compute an identifier for a revision that matched a tag, which doesn't work. We should improve logging in this case: https://build.webkit.org/#/builders/66/builds/541
Comment 1 Radar WebKit Bug Importer 2021-02-26 10:55:02 PST 
<rdar://problem/74797495>
Comment 2 Jonathan Bedard 2021-02-26 10:56:49 PST 
Created attachment 421676 [details]
Patch
Comment 3 Aakash Jain 2021-02-26 11:01:59 PST 
Comment on attachment 421676 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421676&action=review

> Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/svn.py:213
>                  raise self.Exception("Failed to find '{}' on '{}'".format(revision, branch))

This line can be re-worded something like: "Failed to find 'r{}' on branch: '{}'"
Comment 4 Jonathan Bedard 2021-03-02 16:10:54 PST 
Created attachment 422015 [details]
Patch for landing
Comment 5 EWS 2021-03-02 16:56:45 PST 
Committed r273774: <https://commits.webkit.org/r273774>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 422015 [details].