Bug 222474 - [Cocoa] Send QOS parameters as part of Web process creation parameters
Summary: [Cocoa] Send QOS parameters as part of Web process creation parameters
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-26 08:48 PST by Per Arne Vollan
Modified: 2021-02-26 12:23 PST (History)
3 users (show)

See Also:


Attachments
Patch (4.96 KB, patch)
2021-02-26 08:50 PST, Per Arne Vollan
cdumez: review+
cdumez: commit-queue-
Details | Formatted Diff | Diff
Patch (5.61 KB, patch)
2021-02-26 10:30 PST, Per Arne Vollan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2021-02-26 08:48:50 PST
In order to save one IPC call when starting a WebContent process, send QOS parameters as part of Web process creation parameters.
Comment 1 Per Arne Vollan 2021-02-26 08:50:23 PST
Created attachment 421655 [details]
Patch
Comment 2 Chris Dumez 2021-02-26 09:58:52 PST
Comment on attachment 421655 [details]
Patch

r=me
Comment 3 Chris Dumez 2021-02-26 09:59:49 PST
Comment on attachment 421655 [details]
Patch

cq- because I believe you can drop the WebProcess::SetQOS IPC message entirely now. I don't see you updating WebProcess.messages.in in this patch.
Comment 4 Brent Fulgham 2021-02-26 10:00:43 PST
Comment on attachment 421655 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421655&action=review

r=me

> Source/WebKit/UIProcess/WebProcessPool.cpp:-857
> -    process.send(Messages::WebProcess::SetQOS(webProcessLatencyQOS(), webProcessThroughputQOS()), 0);

This appears to be the only use of this WebProcess message. I suggest we remove the message declaration in WebProcess.messages.in, too.
Comment 5 Brent Fulgham 2021-02-26 10:00:59 PST
(In reply to Chris Dumez from comment #3)
> Comment on attachment 421655 [details]
> Patch
> 
> cq- because I believe you can drop the WebProcess::SetQOS IPC message
> entirely now. I don't see you updating WebProcess.messages.in in this patch.

Ha! I was making the same comment!
Comment 6 Per Arne Vollan 2021-02-26 10:21:38 PST
Will fix!

Thanks for reviewing, all!
Comment 7 Per Arne Vollan 2021-02-26 10:30:30 PST
Created attachment 421672 [details]
Patch
Comment 8 EWS 2021-02-26 12:22:36 PST
Committed r273576: <https://commits.webkit.org/r273576>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 421672 [details].
Comment 9 Radar WebKit Bug Importer 2021-02-26 12:23:13 PST
<rdar://problem/74801679>