RESOLVED FIXED Bug 222474
[Cocoa] Send QOS parameters as part of Web process creation parameters 
https://bugs.webkit.org/show_bug.cgi?id=222474
Summary [Cocoa] Send QOS parameters as part of Web process creation parameters
Per Arne Vollan
Reported 2021-02-26 08:48:50 PST
In order to save one IPC call when starting a WebContent process, send QOS parameters as part of Web process creation parameters.
Attachments
Patch (4.96 KB, patch)
2021-02-26 08:50 PST, Per Arne Vollan 		cdumez: review+
cdumez: commit-queue-
DetailsFormatted DiffDiff
Patch (5.61 KB, patch)
2021-02-26 10:30 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2021-02-26 08:50:23 PST
Created attachment 421655 [details] Patch
Chris Dumez
Comment 2 2021-02-26 09:58:52 PST
Comment on attachment 421655 [details] Patch r=me
Chris Dumez
Comment 3 2021-02-26 09:59:49 PST
Comment on attachment 421655 [details] Patch cq- because I believe you can drop the WebProcess::SetQOS IPC message entirely now. I don't see you updating WebProcess.messages.in in this patch.
Brent Fulgham
Comment 4 2021-02-26 10:00:43 PST
Comment on attachment 421655 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=421655&action=review r=me > Source/WebKit/UIProcess/WebProcessPool.cpp:-857 > - process.send(Messages::WebProcess::SetQOS(webProcessLatencyQOS(), webProcessThroughputQOS()), 0); This appears to be the only use of this WebProcess message. I suggest we remove the message declaration in WebProcess.messages.in, too.
Brent Fulgham
Comment 5 2021-02-26 10:00:59 PST
(In reply to Chris Dumez from comment #3) > Comment on attachment 421655 [details] > Patch > > cq- because I believe you can drop the WebProcess::SetQOS IPC message > entirely now. I don't see you updating WebProcess.messages.in in this patch. Ha! I was making the same comment!
Per Arne Vollan
Comment 6 2021-02-26 10:21:38 PST
Will fix! Thanks for reviewing, all!
Per Arne Vollan
Comment 7 2021-02-26 10:30:30 PST
Created attachment 421672 [details] Patch
EWS
Comment 8 2021-02-26 12:22:36 PST
Committed r273576: <https://commits.webkit.org/r273576> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421672 [details].
Radar WebKit Bug Importer
Comment 9 2021-02-26 12:23:13 PST
<rdar://problem/74801679>
Note You need to log in before you can comment on or make changes to this bug.