Bug 222469 - Perform default Web browser check in the UI process
Summary: Perform default Web browser check in the UI process
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-26 05:58 PST by Per Arne Vollan
Modified: 2021-02-26 10:18 PST (History)
2 users (show)

See Also:


Attachments
Patch (5.74 KB, patch)
2021-02-26 06:28 PST, Per Arne Vollan
bfulgham: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2021-02-26 05:58:02 PST
Performing the default Web browser check in the UI process and passing the information on to each WebProcess is a slight performance speedup, since the check only needs to be done once in the UI process, instead of once in every WebContent process.
Comment 1 Radar WebKit Bug Importer 2021-02-26 05:59:00 PST
<rdar://problem/74787714>
Comment 2 Per Arne Vollan 2021-02-26 06:28:53 PST
Created attachment 421635 [details]
Patch
Comment 3 Brent Fulgham 2021-02-26 09:54:13 PST
I'm not sure we want to do this, because it would allow a malicious application to pass an incorrect flag in the message opening up access to sensitive features we don't trust outside of a web browser.
Comment 4 Per Arne Vollan 2021-02-26 10:18:40 PST
(In reply to Brent Fulgham from comment #3)
> I'm not sure we want to do this, because it would allow a malicious
> application to pass an incorrect flag in the message opening up access to
> sensitive features we don't trust outside of a web browser.

Ah, I see!

Thanks for reviewing!