Bug 22246 - Get arguments for opcodes together to eliminate more redundant memory reads
Summary: Get arguments for opcodes together to eliminate more redundant memory reads
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Cameron Zwarich (cpst)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-11-13 16:20 PST by Cameron Zwarich (cpst)
Modified: 2008-11-13 17:40 PST (History)
0 users

See Also:


Attachments
Proposed patch (11.59 KB, patch)
2008-11-13 16:29 PST, Cameron Zwarich (cpst)
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron Zwarich (cpst) 2008-11-13 16:20:49 PST
Currently, if an opcode gets its first operand in eax and its second operand in edx, the read from eax will kill the last result register. Instead, if there is an opportunity for optimization for the second operand we should move eax to edx and then read the first operand from memory into eax.
Comment 1 Cameron Zwarich (cpst) 2008-11-13 16:29:59 PST
Created attachment 25142 [details]
Proposed patch
Comment 2 Darin Adler 2008-11-13 16:33:39 PST
Comment on attachment 25142 [details]
Proposed patch

r=me
Comment 3 Cameron Zwarich (cpst) 2008-11-13 17:40:30 PST
Landed in r38379.