Bug 222458 - Fix crashes due to unsupported pixel formats, program generation issues in Metal Angle backend on Simulator
Summary: Fix crashes due to unsupported pixel formats, program generation issues in Me...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-25 21:38 PST by Kyle Piddington
Modified: 2021-03-05 16:50 PST (History)
5 users (show)

See Also:

Attachments
Patch (216.46 KB, patch)
2021-02-25 21:38 PST, Kyle Piddington 		no flags Details | Formatted Diff | Diff
Patch (218.36 KB, patch)
2021-02-26 01:40 PST, Kyle Piddington 		no flags Details | Formatted Diff | Diff
Patch (239.33 KB, patch)
2021-02-26 11:57 PST, Kyle Piddington 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (239.50 KB, patch)
2021-02-26 12:35 PST, Kyle Piddington 		no flags Details | Formatted Diff | Diff
Patch (238.00 KB, patch)
2021-02-26 16:46 PST, Kyle Piddington 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle Piddington 2021-02-25 21:38:02 PST 
Fix crashes due to unsupported pixel formats, program generation issues in Metal Angle backend on Simulator
Comment 1 Kyle Piddington 2021-02-25 21:38:49 PST 
Created attachment 421607 [details]
Patch
Comment 2 EWS Watchlist 2021-02-25 21:39:53 PST 
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 Kyle Piddington 2021-02-26 01:40:19 PST 
Created attachment 421624 [details]
Patch
Comment 4 Kyle Piddington 2021-02-26 11:57:28 PST 
Created attachment 421688 [details]
Patch
Comment 5 Kyle Piddington 2021-02-26 12:35:48 PST 
Created attachment 421697 [details]
Patch
Comment 6 Dean Jackson 2021-02-26 15:27:25 PST 
Comment on attachment 421697 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421697&action=review

> Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/xcshareddata/xcschemes/WebKitTestRunner.xcscheme:38
> +      launchStyle = "1"
>        useCustomWorkingDirectory = "NO"

Oops. I'll remove this on landing.
Comment 7 Dean Jackson 2021-02-26 15:46:40 PST 
Committed r273597 (234647@main): <https://commits.webkit.org/234647@main>
Comment 8 Radar WebKit Bug Importer 2021-02-26 15:47:16 PST 
<rdar://problem/74811255>
Comment 9 Kyle Piddington 2021-02-26 16:46:38 PST 
Reopening to attach new patch.
Comment 10 Kyle Piddington 2021-02-26 16:46:39 PST 
Created attachment 421727 [details]
Patch
Comment 11 Kyle Piddington 2021-02-26 16:53:17 PST 
Accidentally reopen'd, Dean forgot to mention this was landed.
Committed r273597 (234647@main): <https://commits.webkit.org/234647@main>