Bug 222443 - [resultsdbpy] Use webkitcorepy requests mocking
Summary: [resultsdbpy] Use webkitcorepy requests mocking
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-25 15:52 PST by Jonathan Bedard
Modified: 2021-02-26 13:03 PST (History)
4 users (show)

See Also:

Attachments
Patch (13.91 KB, patch)
2021-02-25 15:56 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2021-02-25 15:52:24 PST 
resultsdbpy should not duplicate requests mocking logic. This is also important because the logic defined in webkitcorepy can be stacked, while the mock structures used in resultsdbpy testing cannot be.
Comment 1 Radar WebKit Bug Importer 2021-02-25 15:52:52 PST 
<rdar://problem/74764567>
Comment 2 Jonathan Bedard 2021-02-25 15:56:25 PST 
Created attachment 421579 [details]
Patch
Comment 3 EWS 2021-02-26 13:03:58 PST 
Committed r273584: <https://commits.webkit.org/r273584>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 421579 [details].