Bug 222413 - [GTK][WPE] Bump libsoup3 version to 2.99.1
Summary: [GTK][WPE] Bump libsoup3 version to 2.99.1
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Keywords: Gtk
Depends on:
Blocks: libsoup3
  Show dependency treegraph
Reported: 2021-02-25 04:48 PST by Carlos Garcia Campos
Modified: 2021-02-26 01:39 PST (History)
12 users (show)

See Also:

Patch (6.91 KB, patch)
2021-02-25 04:50 PST, Carlos Garcia Campos
aperez: review+
aperez: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2021-02-25 04:48:04 PST
Comment 1 Carlos Garcia Campos 2021-02-25 04:50:12 PST
Created attachment 421515 [details]
Comment 2 Adrian Perez 2021-02-26 01:33:05 PST
Comment on attachment 421515 [details]

LGTM with a nit and a comment :)

View in context: https://bugs.webkit.org/attachment.cgi?id=421515&action=review

> Source/WebCore/ChangeLog:8
> +        Use new session getters and setters instead og g_object_get/set.

Typo: og → of

> Source/WebCore/platform/network/soup/SoupNetworkSession.cpp:113
> +    m_soupSession = adoptGRef(soup_session_new_with_options(

I guess the idea to move the initialization of “m_soupSession” here was
because now it's longer but I don't see any other reason to not keep
using the constructor initializer list syntax (and also not needing to
move the “maxConnections” and “maxConnectionsPerHost” constants, I guess?)

In this case it's not much of an issue because a GRefPtr<> is cheap to
construct with the default value, then assign to it inside the constructor
body, so feel free to land as-is =)
Comment 3 Carlos Garcia Campos 2021-02-26 01:39:43 PST
Committed r273545 (234608@main): <https://commits.webkit.org/234608@main>