Bug 222404 – Optimize the code to check if an element delegates focus to its shadow root or not

• Status: RESOLVED
• Resolution: WONTFIX
• Component: DOM

[Ryosuke Niwa]

Split from the bug 222159.

[Ryosuke Niwa]

<rdar://problem/74680265>

[Ryosuke Niwa]

Created attachment 421502 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 421502 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421502&action=review

> Source/WebCore/dom/Node.h:554
> +        DelegatesFocusToShadowRoot = 1 << 27,

If a node DelegatesFocusToShadowRoot, does it already have rare data? If so, could we put this bit in rare data?

[Ryosuke Niwa]

(In reply to Simon Fraser (smfr) from comment #3)
> Comment on attachment 421502 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=421502&action=review
> 
> > Source/WebCore/dom/Node.h:554
> > +        DelegatesFocusToShadowRoot = 1 << 27,
> 
> If a node DelegatesFocusToShadowRoot, does it already have rare data? If so,
> could we put this bit in rare data?

The point of this optimization is to avoid retrieving the rare data.

[Ryosuke Niwa]

Comment on attachment 421502 [details]
Patch

Clearing flags on attachment: 421502

Committed r273474 (234554@main): <https://commits.webkit.org/234554@main>

[Ryosuke Niwa]

All reviewed patches have been landed.  Closing bug.

[WebKit Commit Bot]

Re-opened since this is blocked by bug 222510

[Ryosuke Niwa]

This was not an overall speed up after all.