Bug 222395 - Avoid setting page muted state if unchanged
Summary: Avoid setting page muted state if unchanged
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-24 17:44 PST by Per Arne Vollan
Modified: 2021-02-25 14:18 PST (History)
6 users (show)

See Also:

Attachments
Patch (1.17 KB, patch)
2021-02-24 17:45 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2021-02-24 17:44:04 PST 
Return early in Page::setMuted if muted state did not change.
Comment 1 Per Arne Vollan 2021-02-24 17:45:55 PST 
Created attachment 421489 [details]
Patch
Comment 2 Brent Fulgham 2021-02-25 10:48:35 PST 
Comment on attachment 421489 [details]
Patch

Silly we didn't do this before! r=me.
Comment 3 Per Arne Vollan 2021-02-25 11:51:33 PST 
Comment on attachment 421489 [details]
Patch

Thanks for reviewing!
Comment 4 EWS 2021-02-25 11:55:21 PST 
Committed r273499: <https://commits.webkit.org/r273499>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 421489 [details].
Comment 5 Radar WebKit Bug Importer 2021-02-25 11:56:14 PST 
<rdar://problem/74754341>
Comment 6 Simon Fraser (smfr) 2021-02-25 12:01:37 PST 
Comment on attachment 421489 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421489&action=review

> Source/WebCore/ChangeLog:8
> +        Return early in Page::setMuted if muted state did not change.

Why?
Comment 7 Per Arne Vollan 2021-02-25 14:01:31 PST 
(In reply to Simon Fraser (smfr) from comment #6)
> Comment on attachment 421489 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=421489&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        Return early in Page::setMuted if muted state did not change.
> 
> Why?

This is to avoid work when creating the Web page in WP, and should be a small speedup.

Thanks for reviewing!
Comment 8 Simon Fraser (smfr) 2021-02-25 14:03:25 PST 
(In reply to Per Arne Vollan from comment #7)
> (In reply to Simon Fraser (smfr) from comment #6)
> > Comment on attachment 421489 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=421489&action=review
> > 
> > > Source/WebCore/ChangeLog:8
> > > +        Return early in Page::setMuted if muted state did not change.
> > 
> > Why?
> 
> This is to avoid work when creating the Web page in WP, and should be a
> small speedup.
> 
> Thanks for reviewing!

The changelog should have said that. Is there an associated radar?
Comment 9 Per Arne Vollan 2021-02-25 14:18:55 PST 
(In reply to Simon Fraser (smfr) from comment #8)
> (In reply to Per Arne Vollan from comment #7)
> > (In reply to Simon Fraser (smfr) from comment #6)
> > > Comment on attachment 421489 [details]
> > > Patch
> > > 
> > > View in context:
> > > https://bugs.webkit.org/attachment.cgi?id=421489&action=review
> > > 
> > > > Source/WebCore/ChangeLog:8
> > > > +        Return early in Page::setMuted if muted state did not change.
> > > 
> > > Why?
> > 
> > This is to avoid work when creating the Web page in WP, and should be a
> > small speedup.
> > 
> > Thanks for reviewing!
> 
> The changelog should have said that. Is there an associated radar?

Yes, I agree, that change log entry was too short.

This is the radar: <rdar://problem/74754341>