RESOLVED FIXED Bug 222395
Avoid setting page muted state if unchanged 
https://bugs.webkit.org/show_bug.cgi?id=222395
Summary Avoid setting page muted state if unchanged
Per Arne Vollan
Reported 2021-02-24 17:44:04 PST
Return early in Page::setMuted if muted state did not change.
Attachments
Patch (1.17 KB, patch)
2021-02-24 17:45 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2021-02-24 17:45:55 PST
Created attachment 421489 [details] Patch
Brent Fulgham
Comment 2 2021-02-25 10:48:35 PST
Comment on attachment 421489 [details] Patch Silly we didn't do this before! r=me.
Per Arne Vollan
Comment 3 2021-02-25 11:51:33 PST
Comment on attachment 421489 [details] Patch Thanks for reviewing!
EWS
Comment 4 2021-02-25 11:55:21 PST
Committed r273499: <https://commits.webkit.org/r273499> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421489 [details].
Radar WebKit Bug Importer
Comment 5 2021-02-25 11:56:14 PST
<rdar://problem/74754341>
Simon Fraser (smfr)
Comment 6 2021-02-25 12:01:37 PST
Comment on attachment 421489 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=421489&action=review > Source/WebCore/ChangeLog:8 > + Return early in Page::setMuted if muted state did not change. Why?
Per Arne Vollan
Comment 7 2021-02-25 14:01:31 PST
(In reply to Simon Fraser (smfr) from comment #6) > Comment on attachment 421489 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=421489&action=review > > > Source/WebCore/ChangeLog:8 > > + Return early in Page::setMuted if muted state did not change. > > Why? This is to avoid work when creating the Web page in WP, and should be a small speedup. Thanks for reviewing!
Simon Fraser (smfr)
Comment 8 2021-02-25 14:03:25 PST
(In reply to Per Arne Vollan from comment #7) > (In reply to Simon Fraser (smfr) from comment #6) > > Comment on attachment 421489 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=421489&action=review > > > > > Source/WebCore/ChangeLog:8 > > > + Return early in Page::setMuted if muted state did not change. > > > > Why? > > This is to avoid work when creating the Web page in WP, and should be a > small speedup. > > Thanks for reviewing! The changelog should have said that. Is there an associated radar?
Per Arne Vollan
Comment 9 2021-02-25 14:18:55 PST
(In reply to Simon Fraser (smfr) from comment #8) > (In reply to Per Arne Vollan from comment #7) > > (In reply to Simon Fraser (smfr) from comment #6) > > > Comment on attachment 421489 [details] > > > Patch > > > > > > View in context: > > > https://bugs.webkit.org/attachment.cgi?id=421489&action=review > > > > > > > Source/WebCore/ChangeLog:8 > > > > + Return early in Page::setMuted if muted state did not change. > > > > > > Why? > > > > This is to avoid work when creating the Web page in WP, and should be a > > small speedup. > > > > Thanks for reviewing! > > The changelog should have said that. Is there an associated radar? Yes, I agree, that change log entry was too short. This is the radar: <rdar://problem/74754341>
Note You need to log in before you can comment on or make changes to this bug.