Bug 22238 - Avoid unnecessary reads of temporaries when the target machine register is not eax
Summary: Avoid unnecessary reads of temporaries when the target machine register is no...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Cameron Zwarich (cpst)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-11-13 13:49 PST by Cameron Zwarich (cpst)
Modified: 2008-11-19 13:08 PST (History)
0 users

See Also:


Attachments
Proposed patch (deleted)
2008-11-13 14:04 PST, Cameron Zwarich (cpst)
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron Zwarich (cpst) 2008-11-13 13:49:32 PST
Currently we don't apply the optimization of not reading a value back from memory that we just wrote when the target machine register is not eax. A few opcodes will read into edx and not read into eax. In these cases we could just do a register-register move.
Comment 1 Cameron Zwarich (cpst) 2008-11-13 14:04:14 PST
Created attachment 25134 [details]
Proposed patch
Comment 2 Darin Adler 2008-11-13 14:09:08 PST
Comment on attachment 25134 [details]
Proposed patch

r=me
Comment 3 Cameron Zwarich (cpst) 2008-11-19 13:08:35 PST
Landed in r38377.