RESOLVED FIXED Bug 222370
[ews] Compute identifiers locally 
https://bugs.webkit.org/show_bug.cgi?id=222370
Summary [ews] Compute identifiers locally
Jonathan Bedard
Reported 2021-02-24 11:08:27 PST
We should compute commit identifiers locally instead of reaching out to GitHub.com to compute them.
Attachments
Patch (3.22 KB, patch)
2021-02-24 11:12 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (3.22 KB, patch)
2021-02-24 11:19 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (4.50 KB, patch)
2021-02-24 13:31 PST, Jonathan Bedard 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (7.69 KB, patch)
2021-02-24 15:20 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (22.31 KB, patch)
2021-02-24 15:33 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (22.19 KB, patch)
2021-02-24 15:38 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (22.62 KB, patch)
2021-02-24 15:42 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (23.92 KB, patch)
2021-02-25 09:29 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (24.89 KB, patch)
2021-02-25 10:03 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-02-24 11:10:07 PST
<rdar://problem/74704298>
Jonathan Bedard
Comment 2 2021-02-24 11:12:00 PST
Created attachment 421429 [details] Patch
Aakash Jain
Comment 3 2021-02-24 11:14:28 PST
Also need to delete the GITHUB related change from loadConfig.py
Jonathan Bedard
Comment 4 2021-02-24 11:19:52 PST
Created attachment 421431 [details] Patch
Jonathan Bedard
Comment 5 2021-02-24 13:31:50 PST
Created attachment 421453 [details] Patch
Jonathan Bedard
Comment 6 2021-02-24 15:20:58 PST
Created attachment 421467 [details] Patch
Jonathan Bedard
Comment 7 2021-02-24 15:33:46 PST
Created attachment 421472 [details] Patch
Jonathan Bedard
Comment 8 2021-02-24 15:38:05 PST
Created attachment 421473 [details] Patch
Jonathan Bedard
Comment 9 2021-02-24 15:42:10 PST
Created attachment 421474 [details] Patch
Aakash Jain
Comment 10 2021-02-24 17:48:09 PST
Comment on attachment 421474 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=421474&action=review r+ with comments. > Tools/CISupport/ews-build/steps.py:171 > +class FetchBranches(shell.ShellCommand): Would be good to add uni-tests as well. > Tools/CISupport/ews-build/steps.py:173 > + descriptionDone = ['Update local branch information'] Can re-word as: 'Updated branch information' > Tools/CISupport/ews-build/steps.py:177 > + def __init__(self, **kwargs): Do you want to have a timeout here (like 5 minutes), or use the default 20 minutes timeout? > Tools/CISupport/ews-build/steps.py:183 > + def start(self): Don't need this start method. You can directly define command as a class variable, like: command = ['git', 'fetch'] For e.g.: see CleanUpGitIndexLock.command
Jonathan Bedard
Comment 11 2021-02-25 09:29:15 PST
Created attachment 421531 [details] Patch
Aakash Jain
Comment 12 2021-02-25 09:50:00 PST
Comment on attachment 421531 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=421531&action=review > Tools/CISupport/ews-build/steps_unittest.py:3884 > + self.expectOutcome(result=SUCCESS) Can also verify 'state_string' here.
Jonathan Bedard
Comment 13 2021-02-25 10:03:21 PST
Created attachment 421537 [details] Patch
EWS
Comment 14 2021-02-25 11:05:31 PST
Committed r273496: <https://commits.webkit.org/r273496> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421537 [details].
Note You need to log in before you can comment on or make changes to this bug.