We should compute commit identifiers locally instead of reaching out to GitHub.com to compute them.
<rdar://problem/74704298>
Created attachment 421429 [details] Patch
Also need to delete the GITHUB related change from loadConfig.py
Created attachment 421431 [details] Patch
Created attachment 421453 [details] Patch
Created attachment 421467 [details] Patch
Created attachment 421472 [details] Patch
Created attachment 421473 [details] Patch
Created attachment 421474 [details] Patch
Comment on attachment 421474 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=421474&action=review r+ with comments. > Tools/CISupport/ews-build/steps.py:171 > +class FetchBranches(shell.ShellCommand): Would be good to add uni-tests as well. > Tools/CISupport/ews-build/steps.py:173 > + descriptionDone = ['Update local branch information'] Can re-word as: 'Updated branch information' > Tools/CISupport/ews-build/steps.py:177 > + def __init__(self, **kwargs): Do you want to have a timeout here (like 5 minutes), or use the default 20 minutes timeout? > Tools/CISupport/ews-build/steps.py:183 > + def start(self): Don't need this start method. You can directly define command as a class variable, like: command = ['git', 'fetch'] For e.g.: see CleanUpGitIndexLock.command
Created attachment 421531 [details] Patch
Comment on attachment 421531 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=421531&action=review > Tools/CISupport/ews-build/steps_unittest.py:3884 > + self.expectOutcome(result=SUCCESS) Can also verify 'state_string' here.
Created attachment 421537 [details] Patch
Committed r273496: <https://commits.webkit.org/r273496> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421537 [details].