EWS unit-tests currently work with Buildbot v1.8.2. But on newer buildbot (e.g.: v2.8.4) they fail with error: ====================================================================== ERROR: test_unexpected_failure (steps_unittest.TestWebKitPyPython3Tests) test_unexpected_failure ---------------------------------------------------------------------- Traceback (most recent call last): File "/Library/Python/3.7/site-packages/twisted/internet/defer.py", line 151, in maybeDeferred result = f(*args, **kw) File "/Library/Python/3.7/site-packages/twisted/internet/utils.py", line 221, in runWithWarningsSuppressed reraise(exc_info[1], exc_info[2]) File "/Library/Python/3.7/site-packages/twisted/python/compat.py", line 464, in reraise raise exception.with_traceback(traceback) File "/Library/Python/3.7/site-packages/twisted/internet/utils.py", line 217, in runWithWarningsSuppressed result = f(*a, **kw) File "Tools/CISupport/ews-build/steps_unittest.py", line 542, in setUp return self.setUpBuildStep() File "Tools/CISupport/ews-build/steps_unittest.py", line 114, in setUpBuildStep super(BuildStepMixinAdditions, self).setUpBuildStep() File "/Library/Python/3.7/site-packages/buildbot/test/util/steps.py", line 119, in setUpBuildStep raise Exception('Reactor has not yet been setup for step') Exception: Reactor has not yet been setup for step We should make the unit-tests compatible with newer version of buildbot.
This is because of recent change in Buildbot in https://github.com/buildbot/buildbot/commit/16c2c931a0 (in v2.8.0)
Created attachment 421410 [details] Patch
Committed r273403: <https://commits.webkit.org/r273403> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421410 [details].
<rdar://problem/74698904>