Bug 222352 – [Linux] webkit-patch land does not store credentials in the keyring

• Status: RESOLVED
• Resolution: WONTFIX
• Component: Tools / Tests

[Sergio Villar Senin]

I've been suffering this for a while. Whenever I do "webkit-patch land" I kept being asked for my svn credentials. After I enter them I don't get prompted to store them and they are not effectively stored anywhere.

[Sergio Villar Senin]

Any idea folks?

[Michael Catanzaro]

Hm, webkit-patch secret storage works for me for my Bugzilla credentials, as used by 'webkit-patch upload' or 'webkit-patch land-safely'. It requires python3-secretstorage, but that should be autoinstalled by webkit-patch. (It also requires manually setting 'git config bugzilla.username <email>', which is annoying. We should do that automatically. I digress.)

But I don't have an SVN account since I left Igalia, so I don't test 'webkit-patch land' anymore. It's possible that SVN credential saving is broken but Bugzilla credential saving is not?

[Philippe Normand]

I don't use `land`. Usually I use cq or call `webkit-flatpak -c git svn dcommit` (knowingly of all the consequences) and I'm not prompted for credentials beyond the first commit, so I think SVN credentials caching works as expected, unless webkit-patch does something fancy.

[Sergio Villar Senin]

(In reply to Michael Catanzaro from comment #2)
> Hm, webkit-patch secret storage works for me for my Bugzilla credentials, as
> used by 'webkit-patch upload' or 'webkit-patch land-safely'. It requires
> python3-secretstorage, but that should be autoinstalled by webkit-patch. (It
> also requires manually setting 'git config bugzilla.username <email>', which
> is annoying. We should do that automatically. I digress.)
> 
> But I don't have an SVN account since I left Igalia, so I don't test
> 'webkit-patch land' anymore. It's possible that SVN credential saving is
> broken but Bugzilla credential saving is not?

Everything related to bugzilla is working fine since the last downgrade of packages in flatpak, i.e. webkit-patch upload for example works fine and does not prompt me for my pass.

However I have to set the SVN credentials everytime I have to commit something.

[Philippe Normand]

webkit-patch currently doesn't run in the Flatpak SDK.

[Radar WebKit Bug Importer]

<rdar://problem/75144748>

[Philippe Normand]

I'm not sure, can webkit-patch upload/land patches from bugzilla these days?

I moved to the Github workflow months ago and don't really want to try the bugzilla stuff anymore :)

[Michael Catanzaro]

Let's just close this. If somebody still cares about webkit-patch and wants to make improvements, feel free, but almost everybody is using git-webkit nowadays.