RESOLVED FIXED 222351
[WASM-Function-References] Extend wasm type with type index 
https://bugs.webkit.org/show_bug.cgi?id=222351
Summary [WASM-Function-References] Extend wasm type with type index
Dmitry
Reported 2021-02-24 03:39:53 PST
[WASM-Function-References] Extend wasm type with type index
Attachments
Patch (178.54 KB, patch)
2021-02-24 03:42 PST, Dmitry 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dmitry
Comment 1 2021-02-24 03:42:21 PST
Created attachment 421394 [details] Patch
Keith Miller
Comment 2 2021-02-26 09:37:58 PST
Comment on attachment 421394 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=421394&action=review r=me. > Source/JavaScriptCore/wasm/generateWasmOpsHeader.py:219 > + bool operator==(const Type& other) const Seems like it'd be reasonable to have an implicit TypeKind constructor so you can just use the enum literals as Types.
Dmitry
Comment 3 2021-02-28 21:13:44 PST
There are two reason why we may want not to introduce any user-defined constructors: 1) Now Wasm::Type is a POD type and it is a good property to have, any user-defined constructor breaks this. 2) In the near future not all TypeKind values can represent Wasm::Type, for example - TypeKind::Reference can't represent Type without specifying type_idx wdyt?
Radar WebKit Bug Importer
Comment 4 2021-03-03 03:40:15 PST
<rdar://problem/74978305>
EWS
Comment 5 2021-03-03 04:20:05 PST
Committed r273813: <https://commits.webkit.org/r273813> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421394 [details].
Note You need to log in before you can comment on or make changes to this bug.