Bug 222348 - [GPU Process] Implement ImageBufferShareableBitmapBackend::bytesPerRow()
Summary: [GPU Process] Implement ImageBufferShareableBitmapBackend::bytesPerRow()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-24 01:42 PST by Said Abou-Hallawa
Modified: 2021-02-24 09:53 PST (History)
5 users (show)

See Also:

Attachments
Patch (4.72 KB, patch)
2021-02-24 01:46 PST, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2021-02-24 01:42:15 PST 
The ShareableBitmapCG aligns the rows using IOSurfaceAlignProperty(kIOSurfaceBytesPerRow, ...). This means the default implementation which is "width x 4" is wrong for ImageBufferShareableBitmapBackend.

This will fix the layout failure:

fast/canvas/canvas-large-dimensions.html [ Failure ]
Comment 1 Said Abou-Hallawa 2021-02-24 01:46:08 PST 
Created attachment 421390 [details]
Patch
Comment 2 EWS 2021-02-24 09:52:01 PST 
Committed r273406: <https://commits.webkit.org/r273406>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 421390 [details].
Comment 3 Radar WebKit Bug Importer 2021-02-24 09:53:19 PST 
<rdar://problem/74700179>