Bug 222344 - [Cocoa] Web Inspector: expose the extension host that is used to load _WKInspectorExtension tabs
Summary: [Cocoa] Web Inspector: expose the extension host that is used to load _WKInsp...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: BJ Burg
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-23 21:51 PST by BJ Burg
Modified: 2021-02-24 22:10 PST (History)
4 users (show)

See Also:

Attachments
Patch v1.0 (6.62 KB, patch)
2021-02-23 22:02 PST, BJ Burg 		no flags Details | Formatted Diff | Diff
Patch v2.0 (6.24 KB, patch)
2021-02-24 16:43 PST, BJ Burg 		no flags Details | Formatted Diff | Diff
Patch v2.1 (6.18 KB, patch)
2021-02-24 16:57 PST, BJ Burg 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2021-02-23 21:51:54 PST 
.
Comment 1 Radar WebKit Bug Importer 2021-02-23 21:52:08 PST 
<rdar://problem/74678778>
Comment 2 BJ Burg 2021-02-23 22:02:19 PST 
Created attachment 421384 [details]
Patch v1.0
Comment 3 BJ Burg 2021-02-23 23:20:45 PST 
Comment on attachment 421384 [details]
Patch v1.0

Going a different route.
Comment 4 BJ Burg 2021-02-24 16:43:18 PST 
Created attachment 421482 [details]
Patch v2.0
Comment 5 BJ Burg 2021-02-24 16:57:26 PST 
Created attachment 421483 [details]
Patch v2.1
Comment 6 Devin Rousso 2021-02-24 17:50:19 PST 
Comment on attachment 421483 [details]
Patch v2.1

View in context: https://bugs.webkit.org/attachment.cgi?id=421483&action=review

r=me

> Source/WebKit/UIProcess/API/Cocoa/_WKInspectorExtensionHost.h:66
> +@property (nonatomic, readonly) WKWebView *extensionHostWebView;

NIT: It seems a bit redundant to have `extensionHost` in the name given that this protocol already has that in the name.  If this is ObjC convention tho feel free to ignore :)

Also, seeing as how this is the Web Inspector `WKWebView`, should we maybe just call it as such (e.g. `inspectorWebView`) rather than that being somewhat implicit or explained in the discussion?
Comment 7 BJ Burg 2021-02-24 20:01:05 PST 
(In reply to Devin Rousso from comment #6)
> Comment on attachment 421483 [details]
> Patch v2.1
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=421483&action=review
> 
> r=me
> 
> > Source/WebKit/UIProcess/API/Cocoa/_WKInspectorExtensionHost.h:66
> > +@property (nonatomic, readonly) WKWebView *extensionHostWebView;
> 
> NIT: It seems a bit redundant to have `extensionHost` in the name given that
> this protocol already has that in the name.  If this is ObjC convention tho
> feel free to ignore :)
> 
> Also, seeing as how this is the Web Inspector `WKWebView`, should we maybe
> just call it as such (e.g. `inspectorWebView`) rather than that being
> somewhat implicit or explained in the discussion?

Yes, it's redundant. This is on purpose, to deter folks from doing all kinds of bad things to Inspector's WKWebView subclass because it's easier than adding proper _WKInspectorConfiguartion options or other SPI.
Comment 8 EWS 2021-02-24 22:10:44 PST 
Committed r273471: <https://commits.webkit.org/r273471>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 421483 [details].