Bug 222342 - Remove RemoteCommandListenerIOS
Summary: Remove RemoteCommandListenerIOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jean-Yves Avenard [:jya]
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-23 20:47 PST by Jean-Yves Avenard [:jya]
Modified: 2021-03-03 21:59 PST (History)
2 users (show)

See Also:

Attachments
Patch (50.46 KB, patch)
2021-02-24 21:47 PST, Jean-Yves Avenard [:jya] 		no flags Details | Formatted Diff | Diff
Patch (50.44 KB, patch)
2021-03-03 17:30 PST, Jean-Yves Avenard [:jya] 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jean-Yves Avenard [:jya] 2021-02-23 20:47:12 PST 
Task:
Remove RemoteCommandListenerIOS in favour of RemoteCommandListenerMac to be renamed RemoteCommandListenerCocoa.
Comment 1 Jean-Yves Avenard [:jya] 2021-02-24 21:47:14 PST 
Created attachment 421499 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2021-02-25 19:50:03 PST 
<rdar://problem/74773837>
Comment 3 Eric Carlson 2021-03-03 16:38:57 PST 
Comment on attachment 421499 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421499&action=review

> Source/WebCore/ChangeLog:5
> +

Please add the Radar url here.

> Source/WebCore/platform/cocoa/RemoteCommandListenerCocoa.h:42
> +protected:

Can this be private?
Comment 4 Jean-Yves Avenard [:jya] 2021-03-03 17:28:34 PST 
It can be private, but all I did is rename the file, there wasn't any change to it. will do
Comment 5 Jean-Yves Avenard [:jya] 2021-03-03 17:30:32 PST 
Created attachment 422166 [details]
Patch
Comment 6 EWS 2021-03-03 21:59:30 PST 
Committed r273873: <https://commits.webkit.org/r273873>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 422166 [details].