Bug 222341 - [GPU Process] Tests under imported/blink/fast/canvas are now fixed by r273956
Summary: [GPU Process] Tests under imported/blink/fast/canvas are now fixed by r273956
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-23 19:29 PST by Said Abou-Hallawa
Modified: 2021-03-05 23:52 PST (History)
3 users (show)

See Also:

Attachments
Patch (3.78 KB, patch)
2021-02-23 20:40 PST, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (4.20 KB, patch)
2021-02-24 10:55 PST, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (1.60 KB, patch)
2021-03-05 23:16 PST, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2021-02-23 19:29:17 PST 
This causes the failures in these tests:

imported/blink/fast/canvas/canvas-clip-stack-persistence.html [ ImageOnlyFailure ]
imported/blink/fast/canvas/canvas-state-persistence-no-dirty.html [ ImageOnlyFailure ]
imported/blink/fast/canvas/canvas-unbalanced-save.html [ ImageOnlyFailure ]
Comment 1 Said Abou-Hallawa 2021-02-23 20:40:23 PST 
Created attachment 421382 [details]
Patch
Comment 2 Said Abou-Hallawa 2021-02-24 10:55:50 PST 
Created attachment 421428 [details]
Patch
Comment 3 Radar WebKit Bug Importer 2021-03-02 19:30:16 PST 
<rdar://problem/74964300>
Comment 4 Simon Fraser (smfr) 2021-03-04 10:52:13 PST 
Comment on attachment 421428 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421428&action=review

> Source/WebCore/ChangeLog:8
> +        This is not the ultimate solution. But flushDrawingContext() has a bug

What is the flushDrawingContext() bug?
Comment 5 Said Abou-Hallawa 2021-03-05 23:12:48 PST 
Comment on attachment 421428 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421428&action=review

>> Source/WebCore/ChangeLog:8
>> +        This is not the ultimate solution. But flushDrawingContext() has a bug
> 
> What is the flushDrawingContext() bug?

I was wrong about flushDrawingContext(). I thought there is a synchronization bug with replaying back the DisplayList items in GPUP and getting the NativeImage of the IOSurface in WebP. It turned out it is a 2D canvas compositing issue which was fixed by r273956
Comment 6 Said Abou-Hallawa 2021-03-05 23:16:09 PST 
Created attachment 422475 [details]
Patch
Comment 7 Said Abou-Hallawa 2021-03-05 23:17:29 PST 
I am going to r+ and cq+ this patch since it is just test gardening only.
Comment 8 EWS 2021-03-05 23:52:46 PST 
Committed r274032: <https://commits.webkit.org/r274032>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 422475 [details].