Bug 222337 - [webkitscmpy] Add flag for caller to opt out of identifier computation
Summary: [webkitscmpy] Add flag for caller to opt out of identifier computation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-23 16:35 PST by Jonathan Bedard
Modified: 2021-02-24 14:02 PST (History)
2 users (show)

See Also:

Attachments
Patch (21.95 KB, patch)
2021-02-23 16:41 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2021-02-23 16:35:27 PST 
Identifier computation can be expensive in some cases. Add a flag to opt out of preforming this computation.
Comment 1 Radar WebKit Bug Importer 2021-02-23 16:35:52 PST 
<rdar://problem/74667858>
Comment 2 Jonathan Bedard 2021-02-23 16:41:37 PST 
Created attachment 421369 [details]
Patch
Comment 3 Jonathan Bedard 2021-02-23 16:42:47 PST 
Comment on attachment 421369 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421369&action=review

> Tools/Scripts/libraries/webkitscmpy/setup.py:32
> +    version='0.11.1',

Note for the weird version bump: https://commits.webkit.org/234485@main should have bumped this to 0.11.0, I think I edited the version file in the wrong checkout.
Comment 4 dewei_zhu 2021-02-24 13:57:21 PST 
r=me
Comment 5 EWS 2021-02-24 14:02:39 PST 
Committed r273437: <https://commits.webkit.org/r273437>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 421369 [details].