Bug 222330 - [iOS] Reduce use of retain/release in WAKWindow and remove unneeded methods from that class
Summary: [iOS] Reduce use of retain/release in WAKWindow and remove unneeded methods f...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: iPhone / iPad Unspecified
: P2 Normal
Assignee: Darin Adler
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-23 13:19 PST by Darin Adler
Modified: 2021-02-28 12:56 PST (History)
4 users (show)

See Also:

Attachments
Patch (23.53 KB, patch)
2021-02-23 15:46 PST, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (24.35 KB, patch)
2021-02-23 17:29 PST, Darin Adler 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2021-02-23 13:19:12 PST 
Reduce use of retain/release in WAKWindow and remove unneeded methods from that class
Comment 1 Darin Adler 2021-02-23 15:46:39 PST 
Created attachment 421360 [details]
Patch
Comment 2 Darin Adler 2021-02-23 17:29:47 PST 
Created attachment 421378 [details]
Patch
Comment 3 Chris Dumez 2021-02-23 18:27:26 PST 
Comment on attachment 421378 [details]
Patch

r=me
Comment 4 Chris Dumez 2021-02-24 16:35:48 PST 
Ready to cq+?
Comment 5 Darin Adler 2021-02-24 17:03:48 PST 
I had missed your r=me!
Comment 6 Darin Adler 2021-02-24 17:06:06 PST 
Committed r273462 (234543@main): <https://commits.webkit.org/234543@main>
Comment 7 Radar WebKit Bug Importer 2021-02-24 17:07:20 PST 
<rdar://problem/74721444>
Comment 8 Truitt Savell 2021-02-25 09:34:31 PST 
Reverted r273462 for reason:

Caused API build failures

Committed r273489 (234568@main): <https://commits.webkit.org/234568@main>
Comment 9 Darin Adler 2021-02-25 10:26:08 PST 
Will re-land this once we fix the header dependences in Apple’s internal build system.
Comment 10 EWS 2021-02-28 12:56:45 PST 
Committed r273639: <https://commits.webkit.org/r273639>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 421378 [details].