Cloop JSC test driver command shouldn't pass build flags
Created attachment 421331 [details] Patch
*** Bug 222321 has been marked as a duplicate of this bug. ***
How do we know it is unused? It seems to be passed in https://build.webkit.org/#/builders/39/builds/520/steps/8/logs/stdio If the script ignores this parameter, can we delete this parameter completely from build-jsc (e.g.: https://github.com/WebKit/WebKit/blob/main/Tools/Scripts/build-jsc#L89)
(In reply to Aakash Jain from comment #3) > How do we know it is unused? > It seems to be passed in > https://build.webkit.org/#/builders/39/builds/520/steps/8/logs/stdio Because we are passing --no-build and that's a build flag. AFAIK, no test uses it. > > If the script ignores this parameter, can we delete this parameter > completely from build-jsc (e.g.: > https://github.com/WebKit/WebKit/blob/main/Tools/Scripts/build-jsc#L89) We want it when we don't pass --no-build so we trigger a build with CLoop.
(In reply to Keith Miller from comment #4) > (In reply to Aakash Jain from comment #3) > > How do we know it is unused? > > It seems to be passed in > > https://build.webkit.org/#/builders/39/builds/520/steps/8/logs/stdio > > Because we are passing --no-build and that's a build flag. AFAIK, no test > uses it. No test can ever see it. As --cloop is not recognized by run-javascriptcore-tests (and because we use Getopt::Long qw(:config pass_through)), it ends up in @ARGV after argument parsing. @ARGV is only used in the RHS of an assignment to @buildArgs, which is only ever used if $buildJSC is true. So --cloop is ignored when passing in --no-build to run-javascriptcore-tests (see also #221186).
ok. sounds good.
Committed r273410: <https://commits.webkit.org/r273410> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421331 [details].
<rdar://problem/74704402>