Bug 222314 - [GStreamer][EME][Thunder] Initialize decryptor lazily
Summary: [GStreamer][EME][Thunder] Initialize decryptor lazily
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Xabier Rodríguez Calvar
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-23 07:52 PST by Xabier Rodríguez Calvar
Modified: 2021-02-25 06:39 PST (History)
7 users (show)

See Also:


Attachments
Patch (5.91 KB, patch)
2021-02-23 07:57 PST, Xabier Rodríguez Calvar
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Xabier Rodríguez Calvar 2021-02-23 07:52:47 PST
[GStreamer][EME][Thunder] Initialize decryptor lazily
Comment 1 Xabier Rodríguez Calvar 2021-02-23 07:57:43 PST
Created attachment 421311 [details]
Patch
Comment 2 Philippe Normand 2021-02-23 08:00:50 PST
Comment on attachment 421311 [details]
Patch

ok! please fix coding style though
Comment 3 Xabier Rodríguez Calvar 2021-02-23 08:46:04 PST
Comment on attachment 421311 [details]
Patch

(In reply to Philippe Normand from comment #2)
> Comment on attachment 421311 [details]
> Patch
> 
> ok! please fix coding style though

I can't, part is under an ifdef so if I fix that I have to add another coding style glitch.
Comment 4 EWS 2021-02-23 09:09:57 PST
Committed r273311: <https://commits.webkit.org/r273311>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 421311 [details].
Comment 5 Radar WebKit Bug Importer 2021-02-23 09:10:15 PST
<rdar://problem/74644647>
Comment 6 Philippe Normand 2021-02-25 04:40:04 PST
This introduced a new warning:

[95/830] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/platform/graphics/gstreamer/eme/CDMThunder.cpp.o
../../Source/WebCore/platform/graphics/gstreamer/eme/CDMThunder.cpp:134:457: warning: format specifies type 'unsigned int' but the argument has type 'size_t' (aka 'unsigned long') [-Wformat]
        do{ if ((__builtin_expect (__extension__ ({ int _g_boolean_var_; if ((GST_LEVEL_DEBUG) <= GST_LEVEL_COUNT && (GST_LEVEL_DEBUG) <= _gst_debug_min) _g_boolean_var_ = 1; else _g_boolean_var_ = 0; _g_boolean_var_; }), 0))) { gst_debug_log ((webkitMediaThunderDebugCategory), (GST_LEVEL_DEBUG), "../../Source/WebCore/platform/graphics/gstreamer/eme/CDMThunder.cpp", ((const char*) (__FUNCTION__)), 134, (GObject *) (__null), "%u supported key systems", supportedKeySystems.size()); } }while (0);
                                                                                                                                                                                                                                                                                                                                                                                                                                             ~~                         ^~~~~~~~~~~~~~~~~~~~~~~~~~
                                                                                                                                                                                                                                                                                                                                                                                                                                             %zu
1 warning generated.
Comment 7 Philippe Normand 2021-02-25 06:39:24 PST
Fixed in r273481