Bug 222291 – WebMouseEvent.h should avoid pulling in WebCore headers that know about DOM nodes

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Wenson Hsieh]

WebMouseEvent.h includes PointerEvent.h, which then includes Node.h and a host of other DOM-related headers. Given that WebMouseEvent.h is a shared header included by code running in the UI process, we probably shouldn't.

...this also fixes a unified source build error, seen here: https://ews-build.webkit.org/#/builders/49/builds/9134/steps/8/logs/errors, which happens because `WebCore::UIEvent` collides with the globally namespaced `UIEvent` Objective-C class from UIKit.

[Wenson Hsieh]

Created attachment 421259 [details]
Patch

[EWS Watchlist]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Darin Adler]

Comment on attachment 421259 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421259&action=review

> Source/WebCore/dom/PointerEventTypeNames.h:28
> +namespace WebCore {

Since this header uses WTF::String, it should include <wtf/Forward.h>.

[Wenson Hsieh]

Comment on attachment 421259 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421259&action=review

>> Source/WebCore/dom/PointerEventTypeNames.h:28
>> +namespace WebCore {
> 
> Since this header uses WTF::String, it should include <wtf/Forward.h>.

Fixed, thanks!

[Wenson Hsieh]

Created attachment 421274 [details]
For landing

[EWS]

Committed r273296: <https://commits.webkit.org/r273296>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 421274 [details].

[Radar WebKit Bug Importer]

<rdar://problem/74625080>