Bug 222284 - [Cocoa] Send sandbox extensions for Network Extension services in load parameters
Summary: [Cocoa] Send sandbox extensions for Network Extension services in load parame...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-22 12:28 PST by Per Arne Vollan
Modified: 2021-02-22 18:26 PST (History)
2 users (show)

See Also:

Attachments
Patch (4.25 KB, patch)
2021-02-22 12:33 PST, Per Arne Vollan 		bfulgham: review+
Details | Formatted Diff | Diff
Patch (4.79 KB, patch)
2021-02-22 13:28 PST, Per Arne Vollan 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (4.24 KB, patch)
2021-02-22 13:29 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2021-02-22 12:28:38 PST 
Currently, sandbox extensions for Network Extension are sent from the UI process to the WebContent process when the policy decision is made, but that is not soon enough in all cases. They should also be sent as part of the load parameters.
Comment 1 Per Arne Vollan 2021-02-22 12:30:48 PST 
<rdar://problem/74402532>
Comment 2 Per Arne Vollan 2021-02-22 12:33:20 PST 
Created attachment 421226 [details]
Patch
Comment 3 Brent Fulgham 2021-02-22 12:34:48 PST 
Comment on attachment 421226 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421226&action=review

r=me

> Source/WebKit/ChangeLog:10
> +        policy decision is made, but that is not soon enough in all cases. They should also be sent as part of the load parameters.

Should we remove the policy decision part, since we are doing it at load time now?
Comment 4 Per Arne Vollan 2021-02-22 13:28:12 PST 
Created attachment 421233 [details]
Patch
Comment 5 Per Arne Vollan 2021-02-22 13:29:16 PST 
Created attachment 421234 [details]
Patch
Comment 6 Per Arne Vollan 2021-02-22 13:30:51 PST 
(In reply to Brent Fulgham from comment #3)
> Comment on attachment 421226 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=421226&action=review
> 
> r=me
> 
> > Source/WebKit/ChangeLog:10
> > +        policy decision is made, but that is not soon enough in all cases. They should also be sent as part of the load parameters.
> 
> Should we remove the policy decision part, since we are doing it at load
> time now?

I believe this is still needed, since the order of events can vary.

Thanks for reviewing!
Comment 7 EWS 2021-02-22 16:03:13 PST 
Committed r273286: <https://commits.webkit.org/r273286>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 421234 [details].