Bug 222236 – UserMediaPermissionRequestManagerProxy may be released while computing capture device list

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[Eric Carlson]

UserMediaPermissionRequestManagerProxy::computeFilteredDeviceList should NULL-check after computing capture device list

[Eric Carlson]

<rdar://74480265>

[Eric Carlson]

Created attachment 421110 [details]
Patch

[Peng Liu]

Comment on attachment 421110 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421110&action=review

> Source/WebKit/ChangeLog:3
> +        UserMediaPermissionRequestManagerProxy::computeFilteredDeviceList may be released

Sounds like UserMediaPermissionRequestManagerProxy may be released?

[youenn fablet]

Comment on attachment 421110 [details]
Patch

I guess the issue is log identifier, that is subtle… maybe this is an indication we should not site this in lambdas but just weakptr.

[Eric Carlson]

Created attachment 421198 [details]
Patch for landing

[EWS]

Committed r273265: <https://commits.webkit.org/r273265>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 421198 [details].

[Darin Adler]

Comment on attachment 421198 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=421198&action=review

> Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp:741
> -        if (weakThis)
> -            m_hasFilteredDeviceList = !revealIdsAndLabels;
> -
> +        weakThis->m_hasFilteredDeviceList = !revealIdsAndLabels;

Why capture "this" but use "weakThis" here?

[Eric Carlson]

Reopening to attach new patch.

[Eric Carlson]

Created attachment 421244 [details]
Patch

[Eric Carlson]

Comment on attachment 421198 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=421198&action=review

>> Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp:741
>> +        weakThis->m_hasFilteredDeviceList = !revealIdsAndLabels;
> 
> Why capture "this" but use "weakThis" here?

Oops, that is left over from a bigger refactoring I (tried to) undo to make this a more targeted change. I'll remove it in a follow.

[EWS]

Committed r273289: <https://commits.webkit.org/r273289>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 421244 [details].

[Eric Carlson]

*** Bug 223476 has been marked as a duplicate of this bug. ***