UserMediaPermissionRequestManagerProxy::computeFilteredDeviceList should NULL-check after computing capture device list
<rdar://74480265>
Created attachment 421110 [details] Patch
Comment on attachment 421110 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=421110&action=review > Source/WebKit/ChangeLog:3 > + UserMediaPermissionRequestManagerProxy::computeFilteredDeviceList may be released Sounds like UserMediaPermissionRequestManagerProxy may be released?
Comment on attachment 421110 [details] Patch I guess the issue is log identifier, that is subtle… maybe this is an indication we should not site this in lambdas but just weakptr.
Created attachment 421198 [details] Patch for landing
Committed r273265: <https://commits.webkit.org/r273265> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421198 [details].
Comment on attachment 421198 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=421198&action=review > Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp:741 > - if (weakThis) > - m_hasFilteredDeviceList = !revealIdsAndLabels; > - > + weakThis->m_hasFilteredDeviceList = !revealIdsAndLabels; Why capture "this" but use "weakThis" here?
Reopening to attach new patch.
Created attachment 421244 [details] Patch
Comment on attachment 421198 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=421198&action=review >> Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp:741 >> + weakThis->m_hasFilteredDeviceList = !revealIdsAndLabels; > > Why capture "this" but use "weakThis" here? Oops, that is left over from a bigger refactoring I (tried to) undo to make this a more targeted change. I'll remove it in a follow.
Committed r273289: <https://commits.webkit.org/r273289> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421244 [details].
*** Bug 223476 has been marked as a duplicate of this bug. ***