Bug 22222 - selectKeyViewPrecedingView: with document view that can't be first responder makes WebFrameView be first responder
Summary: selectKeyViewPrecedingView: with document view that can't be first responder ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-11-12 16:42 PST by Darin Adler
Modified: 2008-11-15 10:06 PST (History)
0 users

See Also:

Attachments
patch (3.61 KB, patch)
2008-11-12 16:56 PST, Darin Adler 		mrowe: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2008-11-12 16:42:29 PST 
This came up while doing some Safari experimentation; it doesn't currently affect Safari.

Calling -[NSWindow selectKeyViewPrecedingView:] was causing the WebFrameView to become the first responder. I tracked it down to a bug in -[WebFrameView becomeFirstResponder] that is easy to fix.
Comment 1 Darin Adler 2008-11-12 16:56:21 PST 
Created attachment 25107 [details]
patch
Comment 2 Mark Rowe (bdash) 2008-11-12 22:23:16 PST 
Comment on attachment 25107 [details]
patch

> +        // If we couldn't find a previous valid key view, ask the WebView. This handles frameset
> +        // cases like. Note that previousValidKeyView should never be self but can be due to
> +        // AppKit oddness.

The second sentence of this comment has lost the Radar number.

r=me
Comment 3 Darin Adler 2008-11-15 10:06:28 PST 
http://trac.webkit.org/changeset/38402