Bug 222206 - Add back old media playback API but deprecated
Summary: Add back old media playback API but deprecated
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: katherine_cheney
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-19 15:06 PST by katherine_cheney
Modified: 2021-02-19 17:07 PST (History)
5 users (show)

See Also:


Attachments
Patch (3.94 KB, patch)
2021-02-19 15:11 PST, katherine_cheney
no flags Details | Formatted Diff | Diff
Patch for landing (4.05 KB, patch)
2021-02-19 15:54 PST, katherine_cheney
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description katherine_cheney 2021-02-19 15:06:33 PST
We should add these back in case clients adopted them before the name update in https://trac.webkit.org/changeset/272923/webkit.
Comment 1 Radar WebKit Bug Importer 2021-02-19 15:07:24 PST
<rdar://problem/74539125>
Comment 2 katherine_cheney 2021-02-19 15:11:08 PST
Created attachment 421041 [details]
Patch
Comment 3 Tim Horton 2021-02-19 15:14:42 PST
Comment on attachment 421041 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421041&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.h:529
> +- (void)pauseAllMediaPlayback:(void (^_Nullable)(void))completionHandler WK_API_DEPRECATED_WITH_REPLACEMENT("pauseAllMediaPlaybackWithCompletionHandler", macos(WK_MAC_TBA), ios(WK_IOS_TBA));

I think the deprecation macros take ranges, which in your case are perhaps like macos(WK_MAC_TBA, WK_MAC_TBA)?
Comment 4 katherine_cheney 2021-02-19 15:54:12 PST
Created attachment 421049 [details]
Patch for landing
Comment 5 EWS 2021-02-19 17:07:51 PST
Committed r273186: <https://commits.webkit.org/r273186>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 421049 [details].