WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
222206
Add back old media playback API but deprecated
https://bugs.webkit.org/show_bug.cgi?id=222206
Summary
Add back old media playback API but deprecated
Kate Cheney
Reported
2021-02-19 15:06:33 PST
We should add these back in case clients adopted them before the name update in
https://trac.webkit.org/changeset/272923/webkit
.
Attachments
Patch
(3.94 KB, patch)
2021-02-19 15:11 PST
,
Kate Cheney
no flags
Details
Formatted Diff
Diff
Patch for landing
(4.05 KB, patch)
2021-02-19 15:54 PST
,
Kate Cheney
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2021-02-19 15:07:24 PST
<
rdar://problem/74539125
>
Kate Cheney
Comment 2
2021-02-19 15:11:08 PST
Created
attachment 421041
[details]
Patch
Tim Horton
Comment 3
2021-02-19 15:14:42 PST
Comment on
attachment 421041
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=421041&action=review
> Source/WebKit/UIProcess/API/Cocoa/WKWebView.h:529 > +- (void)pauseAllMediaPlayback:(void (^_Nullable)(void))completionHandler WK_API_DEPRECATED_WITH_REPLACEMENT("pauseAllMediaPlaybackWithCompletionHandler", macos(WK_MAC_TBA), ios(WK_IOS_TBA));
I think the deprecation macros take ranges, which in your case are perhaps like macos(WK_MAC_TBA, WK_MAC_TBA)?
Kate Cheney
Comment 4
2021-02-19 15:54:12 PST
Created
attachment 421049
[details]
Patch for landing
EWS
Comment 5
2021-02-19 17:07:51 PST
Committed
r273186
: <
https://commits.webkit.org/r273186
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 421049
[details]
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug