Bug 222186 - [MotionMark] Make PaintTimingEnabled default to false
Summary: [MotionMark] Make PaintTimingEnabled default to false
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-19 11:53 PST by Said Abou-Hallawa
Modified: 2021-02-21 11:53 PST (History)
5 users (show)

See Also:


Attachments
Patch (1.30 KB, patch)
2021-02-19 11:57 PST, Said Abou-Hallawa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2021-02-19 11:53:49 PST
PaintTiming causes about 4% regression in the MotionMark sub-tests: Multiply and Focus. Do disable it for now.
Comment 1 Said Abou-Hallawa 2021-02-19 11:54:35 PST
<rdar://problem/73416302>
Comment 2 Said Abou-Hallawa 2021-02-19 11:57:31 PST
Created attachment 421004 [details]
Patch
Comment 3 EWS 2021-02-20 14:43:44 PST
Committed r273207: <https://commits.webkit.org/r273207>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 421004 [details].
Comment 4 Noam Rosenthal 2021-02-21 11:15:45 PST
I believe that the root cause is fixed here: https://trac.webkit.org/changeset/273220/webkit

I don't have the means to test the effect on MotionMark result, as locally it doesn't produce consistent results for me.

Said, Can you or someone else with access to the consistent testing environment help make sure that this is true and perhaps revert this patch?

Thanks!
Comment 5 Simon Fraser (smfr) 2021-02-21 11:53:55 PST
Re-enabling via bug 222250.