Bug 222182 – [ macOS Wk2 ] 2X builtins-generator-tests are failing

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: New Bugs

[Robert Jenner]

JavaScriptCore/Scripts/tests/builtins/expected/WebCoreJSBuiltins.h-result
and 
JavaScriptCore/Scripts/tests/builtins/expected/WebCore-GuardedInternalBuiltin-Separate.js-result

are failing in macOS release in Wk2. 

FAILURE TEXT:
PASS: JavaScriptCore-Builtin.prototype-Combined.js-result
PASS: JavaScriptCore-BuiltinConstructor-Separate.js-result
PASS: WebCore-UnguardedBuiltin-Separate.js-result
PASS: WebCore-ArbitraryConditionalGuard-Separate.js-result
PASS: JavaScriptCore-Builtin.Promise-Combined.js-result
PASS: WebCore-DuplicateKeyValueAnnotation-Separate.js-error
FAIL: WebCore-GuardedInternalBuiltin-Separate.js-result
--- JavaScriptCore/Scripts/tests/builtins/expected/WebCore-GuardedInternalBuiltin-Separate.js-result	2021-02-02 16:43:22.000000000 -0800
+++ /var/folders/10/_3cn9dz55qb0vv0d_8_7qmzh0000gn/T/tmpXloMB3builtin-generator-tests/WebCore-GuardedInternalBuiltin-Separate.js-result	2021-02-19 09:25:16.000000000 -0800
@@ -127,7 +127,7 @@
     explicit GuardedInternalBuiltinBuiltinFunctions(JSC::VM& vm) : m_vm(vm) { }
 
     void init(JSC::JSGlobalObject&);
-    void visit(JSC::SlotVisitor&);
+    template<typename Visitor> void visit(Visitor&);
 
 public:
     JSC::VM& m_vm;
@@ -146,13 +146,18 @@
 #undef EXPORT_FUNCTION
 }
 
-inline void GuardedInternalBuiltinBuiltinFunctions::visit(JSC::SlotVisitor& visitor)
+template<typename Visitor>
+inline void GuardedInternalBuiltinBuiltinFunctions::visit(Visitor& visitor)
 {
 #define VISIT_FUNCTION(name) visitor.append(m_##name##Function);
     WEBCORE_FOREACH_GUARDEDINTERNALBUILTIN_BUILTIN_FUNCTION_NAME(VISIT_FUNCTION)
 #undef VISIT_FUNCTION
 }
 
+template void GuardedInternalBuiltinBuiltinFunctions::visit(JSC::AbstractSlotVisitor&);
+template void GuardedInternalBuiltinBuiltinFunctions::visit(JSC::SlotVisitor&);
+
+
 
 } // namespace WebCore
 
PASS: WebCore-DuplicateFlagAnnotation-Separate.js-error
FAIL: WebCore-xmlCasingTest-Separate.js-result
--- JavaScriptCore/Scripts/tests/builtins/expected/WebCore-xmlCasingTest-Separate.js-result	2021-02-02 16:43:22.000000000 -0800
+++ /var/folders/10/_3cn9dz55qb0vv0d_8_7qmzh0000gn/T/tmplmyepdbuiltin-generator-tests/WebCore-xmlCasingTest-Separate.js-result	2021-02-19 09:25:16.000000000 -0800
@@ -143,7 +143,7 @@
     explicit xmlCasingTestBuiltinFunctions(JSC::VM& vm) : m_vm(vm) { }
 
     void init(JSC::JSGlobalObject&);
-    void visit(JSC::SlotVisitor&);
+    template<typename Visitor> void visit(Visitor&);
 
 public:
     JSC::VM& m_vm;
@@ -162,13 +162,18 @@
 #undef EXPORT_FUNCTION
 }
 
-inline void xmlCasingTestBuiltinFunctions::visit(JSC::SlotVisitor& visitor)
+template<typename Visitor>
+inline void xmlCasingTestBuiltinFunctions::visit(Visitor& visitor)
 {
 #define VISIT_FUNCTION(name) visitor.append(m_##name##Function);
     WEBCORE_FOREACH_XMLCASINGTEST_BUILTIN_FUNCTION_NAME(VISIT_FUNCTION)
 #undef VISIT_FUNCTION
 }
 
+template void xmlCasingTestBuiltinFunctions::visit(JSC::AbstractSlotVisitor&);
+template void xmlCasingTestBuiltinFunctions::visit(JSC::SlotVisitor&);
+
+
 
 } // namespace WebCore
 
PASS: JavaScriptCore-BuiltinConstructor-Combined.js-result
PASS: JavaScriptCore-Builtin.prototype-Separate.js-result
FAIL: WebCore-AnotherGuardedInternalBuiltin-Separate.js-result
--- JavaScriptCore/Scripts/tests/builtins/expected/WebCore-AnotherGuardedInternalBuiltin-Separate.js-result	2021-02-02 16:43:22.000000000 -0800
+++ /var/folders/10/_3cn9dz55qb0vv0d_8_7qmzh0000gn/T/tmpkSTaCpbuiltin-generator-tests/WebCore-AnotherGuardedInternalBuiltin-Separate.js-result	2021-02-19 09:25:16.000000000 -0800
@@ -126,7 +126,7 @@
     explicit AnotherGuardedInternalBuiltinBuiltinFunctions(JSC::VM& vm) : m_vm(vm) { }
 
     void init(JSC::JSGlobalObject&);
-    void visit(JSC::SlotVisitor&);
+    template<typename Visitor> void visit(Visitor&);
 
 public:
     JSC::VM& m_vm;
@@ -145,13 +145,18 @@
 #undef EXPORT_FUNCTION
 }
 
-inline void AnotherGuardedInternalBuiltinBuiltinFunctions::visit(JSC::SlotVisitor& visitor)
+template<typename Visitor>
+inline void AnotherGuardedInternalBuiltinBuiltinFunctions::visit(Visitor& visitor)
 {
 #define VISIT_FUNCTION(name) visitor.append(m_##name##Function);
     WEBCORE_FOREACH_ANOTHERGUARDEDINTERNALBUILTIN_BUILTIN_FUNCTION_NAME(VISIT_FUNCTION)
 #undef VISIT_FUNCTION
 }
 
+template void AnotherGuardedInternalBuiltinBuiltinFunctions::visit(JSC::AbstractSlotVisitor&);
+template void AnotherGuardedInternalBuiltinBuiltinFunctions::visit(JSC::SlotVisitor&);
+
+
 
 } // namespace WebCore
 
PASS: JavaScriptCore-Builtin.Promise-Separate.js-result
PASS: WebCore-GuardedBuiltin-Separate.js-result
PASS: JavaScriptCore-InternalClashingNames-Combined.js-error
PASS: JavaScriptCore-InternalClashingNames-Combined.js-result
FAIL: WebCoreJSBuiltins.h-result
--- JavaScriptCore/Scripts/tests/builtins/expected/WebCoreJSBuiltins.h-result	2021-02-02 16:43:22.000000000 -0800
+++ /var/folders/10/_3cn9dz55qb0vv0d_8_7qmzh0000gn/T/tmpaXF4GWbuiltin-generator-tests/WebCoreJSBuiltins.h-result	2021-02-19 09:25:17.000000000 -0800
@@ -199,7 +199,7 @@
 public:
     explicit JSBuiltinInternalFunctions(JSC::VM&);
 
-    void visit(JSC::SlotVisitor&);
+    template<typename Visitor> void visit(Visitor&);
     void initialize(JSDOMGlobalObject&);
 
 #if ENABLE(FETCH_API)
@@ -286,7 +286,8 @@
     UNUSED_PARAM(vm);
 }
 
-void JSBuiltinInternalFunctions::visit(JSC::SlotVisitor& visitor)
+template<typename Visitor>
+void JSBuiltinInternalFunctions::visit(Visitor& visitor)
 {
 #if ENABLE(FETCH_API)
     m_anotherGuardedInternalBuiltin.visit(visitor);
@@ -300,6 +301,9 @@
     UNUSED_PARAM(visitor);
 }
 
+template void JSBuiltinInternalFunctions::visit(AbstractSlotVisitor&);
+template void JSBuiltinInternalFunctions::visit(SlotVisitor&);
+
 void JSBuiltinInternalFunctions::initialize(JSDOMGlobalObject& globalObject)
 {
     UNUSED_PARAM(globalObject);
Some tests FAIL! (To update the reference files, execute "run-builtins-generator-tests --reset-results")
program finished with exit code 255
elapsedTime=1.254936

[Radar WebKit Bug Importer]

<rdar://problem/74528501>

[Robert Jenner]

Looking at builders page:
https://build.webkit.org/#/builders/70

It appears this started at r273138.

CHANGESET URL:
https://trac.webkit.org/changeset/273138/webkit

[Mark Lam]

Oops ... I also created another bugzilla that implemented the fix.  Will dupe this to that one.

[Mark Lam]

*** This bug has been marked as a duplicate of bug 222184 ***