[JSC] Remove vm.topCallFrame storing in Baseline JIT

[Yusuke Suzuki]

[JSC] Remove vm.topCallFrame storing in Baseline JIT

[Yusuke Suzuki]

Created attachment 420935 [details]
Patch

[Mark Lam]

Comment on attachment 420935 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420935&action=review

> Source/JavaScriptCore/ChangeLog:9
> +        This patch removes vm.topCallFrame storing in Baseline JIT since operation / slow-path-call can retrieve CallFrame* via
> +        __builtin_frame_address or callFrame argument.

After discussing the intent of this patch with Yusuke offline, I suggest rephrasing this as "This patch removes vm.topCallFrame storing in the Baseline JIT for ports that can USE(BUILTIN_FRAME_ADDRESS).  Also refactored some CommonSlowPath functions so that they can start using __builtin_frame_address later instead of the requiring that CallFrame be passed in."

[Mark Lam]

r=me

[Mark Lam]

(In reply to Mark Lam from comment #2)
> After discussing the intent of this patch with Yusuke offline, I suggest
> rephrasing this as "This patch removes vm.topCallFrame storing in the
> Baseline JIT for ports that can USE(BUILTIN_FRAME_ADDRESS).  Also refactored
> some CommonSlowPath functions so that they can start using
> __builtin_frame_address later instead of the requiring that CallFrame be
> passed in."

Looks like I had a typo:

/instead of the requiring/instead of requiring/

[Yusuke Suzuki]

Committed r273217 (234403@main): <https://commits.webkit.org/234403@main>

[Radar WebKit Bug Importer]

<rdar://problem/74566597>