RESOLVED FIXED222162
[JSC] Remove vm.topCallFrame storing in Baseline JIT 
https://bugs.webkit.org/show_bug.cgi?id=222162
Summary [JSC] Remove vm.topCallFrame storing in Baseline JIT
Yusuke Suzuki
Reported 2021-02-19 00:31:57 PST
[JSC] Remove vm.topCallFrame storing in Baseline JIT
Attachments
Patch (5.15 KB, patch)
2021-02-19 00:40 PST, Yusuke Suzuki 		mark.lam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2021-02-19 00:40:16 PST
Created attachment 420935 [details] Patch
Mark Lam
Comment 2 2021-02-19 01:06:23 PST
Comment on attachment 420935 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=420935&action=review > Source/JavaScriptCore/ChangeLog:9 > + This patch removes vm.topCallFrame storing in Baseline JIT since operation / slow-path-call can retrieve CallFrame* via > + __builtin_frame_address or callFrame argument. After discussing the intent of this patch with Yusuke offline, I suggest rephrasing this as "This patch removes vm.topCallFrame storing in the Baseline JIT for ports that can USE(BUILTIN_FRAME_ADDRESS). Also refactored some CommonSlowPath functions so that they can start using __builtin_frame_address later instead of the requiring that CallFrame be passed in."
Mark Lam
Comment 3 2021-02-19 01:06:32 PST
r=me
Mark Lam
Comment 4 2021-02-19 01:29:48 PST
(In reply to Mark Lam from comment #2) > After discussing the intent of this patch with Yusuke offline, I suggest > rephrasing this as "This patch removes vm.topCallFrame storing in the > Baseline JIT for ports that can USE(BUILTIN_FRAME_ADDRESS). Also refactored > some CommonSlowPath functions so that they can start using > __builtin_frame_address later instead of the requiring that CallFrame be > passed in." Looks like I had a typo: /instead of the requiring/instead of requiring/
Yusuke Suzuki
Comment 5 2021-02-21 04:37:47 PST
Committed r273217 (234403@main): <https://commits.webkit.org/234403@main>
Radar WebKit Bug Importer
Comment 6 2021-02-21 04:38:16 PST
<rdar://problem/74566597>
Note You need to log in before you can comment on or make changes to this bug.