Bug 222151 - Correctly retain properties in _WKAppHighlight
Summary: Correctly retain properties in _WKAppHighlight
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Megan Gardner
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-18 17:58 PST by Megan Gardner
Modified: 2021-02-18 18:19 PST (History)
2 users (show)

See Also:

Attachments
Patch (2.90 KB, patch)
2021-02-18 17:59 PST, Megan Gardner 		no flags Details | Formatted Diff | Diff
Patch (2.78 KB, patch)
2021-02-18 18:07 PST, Megan Gardner 		wenson_hsieh: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Megan Gardner 2021-02-18 17:58:43 PST 
Correctly retain properties in _WKAppHighlight
Comment 1 Megan Gardner 2021-02-18 17:59:45 PST 
Created attachment 420891 [details]
Patch
Comment 2 Wenson Hsieh 2021-02-18 18:05:29 PST 
Comment on attachment 420891 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420891&action=review

> Source/WebKit/UIProcess/API/Cocoa/_WKAppHighlight.mm:45
> +    _highlight = adoptNS(highlight);
> +    _text = adoptNS(text);
> +    _image = adoptNS(image);

This will overrelease the arguments, since they're not +1 objects.
Comment 3 Megan Gardner 2021-02-18 18:07:22 PST 
Created attachment 420893 [details]
Patch
Comment 4 Megan Gardner 2021-02-18 18:18:22 PST 
Committed r273119 (234316@main): <https://commits.webkit.org/234316@main>
Comment 5 Radar WebKit Bug Importer 2021-02-18 18:19:12 PST 
<rdar://problem/74503732>