RESOLVED FIXED 222126
Fix null dereferencing in RangeResponseGenerator::giveResponseToTasksWithFinishedRanges 
https://bugs.webkit.org/show_bug.cgi?id=222126
Summary Fix null dereferencing in RangeResponseGenerator::giveResponseToTasksWithFini...
Alex Christensen
Reported 2021-02-18 12:58:15 PST
Fix null dereferencing in RangeResponseGenerator::giveResponseToTasksWithFinishedRanges
Attachments
Patch (3.32 KB, patch)
2021-02-18 12:59 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (3.83 KB, patch)
2021-02-18 13:15 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2021-02-18 12:59:27 PST
Created attachment 420864 [details] Patch
Darin Adler
Comment 2 2021-02-18 13:08:18 PST
Comment on attachment 420864 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=420864&action=review > Source/WebCore/platform/network/cocoa/RangeResponseGenerator.mm:274 > m_generator->giveResponseToTasksWithFinishedRanges(*data); I think it’s clearer to write: protectedThis->m_generator->giveResponseToTasksWithFinishedRanges(*data); But I’m not sure anyone else in this project agrees with me! Also, I think that Ryosuke said our overall strategy is to protect differently than this; it would be the caller who should be doing ref/deref, not this function protecting itself. So the fix would be in RemoteMediaResourceManager::loadFinished, which should be using a RefPtr for its local variable.
Alex Christensen
Comment 3 2021-02-18 13:15:35 PST
Created attachment 420866 [details] Patch
Alex Christensen
Comment 4 2021-02-18 15:14:49 PST
r273103
Note You need to log in before you can comment on or make changes to this bug.