Bug 222120 - [macOS] Re-add fsctl support for marking files as potentially 'hot'
Summary: [macOS] Re-add fsctl support for marking files as potentially 'hot'
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-18 11:00 PST by Brent Fulgham
Modified: 2021-02-18 16:47 PST (History)
3 users (show)

See Also:


Attachments
Patch (1.33 KB, patch)
2021-02-18 11:04 PST, Brent Fulgham
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2021-02-18 11:00:51 PST
In Bug 221002 we removed access to a specific fsctl-command. We discovered that this is needed in certain cases to support. This patch adds this ability back and provides documentation for future use.
Comment 1 Brent Fulgham 2021-02-18 11:01:23 PST
<rdar://problem/74387453>
Comment 2 Brent Fulgham 2021-02-18 11:04:01 PST
Created attachment 420849 [details]
Patch
Comment 3 Per Arne Vollan 2021-02-18 11:10:48 PST
Comment on attachment 420849 [details]
Patch

Thanks! R=me.
Comment 4 EWS 2021-02-18 15:08:34 PST
Found 1 new test failure: media/modern-media-controls/volume-support/volume-support-drag.html
Comment 5 Brent Fulgham 2021-02-18 15:42:42 PST
(In reply to EWS from comment #4)
> Found 1 new test failure:
> media/modern-media-controls/volume-support/volume-support-drag.html

This test seems very flaky throughout its history.
Comment 6 Brent Fulgham 2021-02-18 15:43:38 PST
(In reply to Brent Fulgham from comment #5)
> (In reply to EWS from comment #4)
> > Found 1 new test failure:
> > media/modern-media-controls/volume-support/volume-support-drag.html
> 
> This test seems very flaky throughout its history.

Also: This change rolls out a change, so seems unlikely to introduce a new test failure (since it's just restoring something that used to be allowed by the sandbox).
Comment 7 EWS 2021-02-18 16:47:46 PST
Committed r273114: <https://commits.webkit.org/r273114>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 420849 [details].