Bug 222114 – HTMLModelElement needs a renderer

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Sam Weinig]

HTMLModelElement needs a renderer. Let's add RenderModel.

[Sam Weinig]

Created attachment 421251 [details]
Patch

[Sam Weinig]

Patch looks bigger than it is due a binary file at the bottom. Don't be scared.

[Simon Fraser (smfr)]

Comment on attachment 421251 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421251&action=review

> Source/WebCore/Modules/model-element/HTMLModelElement.cpp:47
> +    , m_dataComplete { false }

Remove

> Source/WebCore/Modules/model-element/HTMLModelElement.cpp:186
> +    if (resource.loadFailedOrCanceled()) {
> +        m_data = nullptr;
> +
> +        m_resource->removeClient(*this);
> +        m_resource = nullptr;
> +
> +        if (auto* renderer = this->renderer())
> +            renderer->updateFromElement();
> +
> +        m_readyPromise->reject(Exception { NetworkError });
> +    } else {
> +        m_dataComplete = true;
> +
> +        m_resource->removeClient(*this);
> +        m_resource = nullptr;
> +
> +        if (auto* renderer = this->renderer())
> +            renderer->updateFromElement();
> +
> +        m_readyPromise->resolve(*this);
> +    }

I feel like an early return here somewhere would be nicer. Share the common bits in a lambda.

> Source/WebCore/Modules/model-element/HTMLModelElement.h:75
> +    bool m_dataComplete;

{ false }
Put small things after big things to minimize padding.

[Sam Weinig]

Created attachment 421267 [details]
Patch

[EWS]

Committed r273290: <https://commits.webkit.org/r273290>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 421267 [details].

[Radar WebKit Bug Importer]

<rdar://problem/74622391>

[Aakash Jain]

(In reply to EWS from comment #5)
> Committed r273290: <https://commits.webkit.org/r273290>
Following layout-tests added in this commit seems to be consistently failing on iOS:

model-element/model-element-renderer.html 
model-element/model-element-renderer-no-source.html

History: https://results.webkit.org/?suite=layout-tests&suite=layout-tests&test=model-element%2Fmodel-element-renderer-no-source.html&test=model-element%2Fmodel-element-renderer.html

[Aakash Jain]

Diff (from: https://ews-build.s3-us-west-2.amazonaws.com/iOS-14-Simulator-WK2-Tests-EWS/r421275-7501-clean-tree/model-element/model-element-renderer-no-source-diff.txt):

-layer at (0,0) size 800x170
-  RenderBlock {HTML} at (0,0) size 800x170
-    RenderBody {BODY} at (8,8) size 784x154
+layer at (0,0) size 800x171
+  RenderBlock {HTML} at (0,0) size 800x171
+    RenderBody {BODY} at (8,8) size 784x155

[Sam Weinig]

Working on the test fix in https://bugs.webkit.org/show_bug.cgi?id=222323.

[Antoine Quint]

*** Bug 219114 has been marked as a duplicate of this bug. ***