Bug 222111 - Clean up ScrollableArea and ScrollAnimator API and convert less between offsets and positions
Summary: Clean up ScrollableArea and ScrollAnimator API and convert less between offse...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Scrolling (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Martin Robinson
URL:
Keywords: InRadar
Depends on:
Blocks: 146696
  Show dependency tree / graph
 
Reported: 2021-02-18 08:59 PST by Martin Robinson
Modified: 2021-02-22 13:40 PST (History)
9 users (show)

See Also:

Attachments
Patch (31.78 KB, patch)
2021-02-19 05:01 PST, Martin Robinson 		no flags Details | Formatted Diff | Diff
Patch (32.12 KB, patch)
2021-02-19 08:16 PST, Martin Robinson 		no flags Details | Formatted Diff | Diff
Patch (32.32 KB, patch)
2021-02-22 00:28 PST, Martin Robinson 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2021-02-18 08:59:06 PST 
The ScrollableArea and ScrollAnimator API is a bit confusing when it comes to scrolling to offsets and positions. It isn't always clear when these APIs will trigger an animation and we are missing some opportunities to use "native" animations on Mac. These APIs also require a lot of conversion back and forth between offsets and positions. Finally, cleaning up this API will allow us to use native animations to do scroll snapping during thumb dragging.
Comment 1 Martin Robinson 2021-02-19 05:01:20 PST 
Created attachment 420957 [details]
Patch
Comment 2 Martin Robinson 2021-02-19 08:16:50 PST 
Created attachment 420970 [details]
Patch
Comment 3 Martin Robinson 2021-02-22 00:28:25 PST 
Created attachment 421167 [details]
Patch
Comment 4 EWS 2021-02-22 13:39:45 PST 
Committed r273275: <https://commits.webkit.org/r273275>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 421167 [details].
Comment 5 Radar WebKit Bug Importer 2021-02-22 13:40:15 PST 
<rdar://problem/74611765>