Bug 222099 – RemoteRenderingBackend commands are not processed in order if GPU process is waiting for replies

• Status: RESOLVED
• Resolution: FIXED
• Component: Canvas

[Kimmo Kinnunen]

RemoteRenderingBackend commands are not processed in order if GPU process is waiting for replies

Asynchronous messages need to be sent with DispatchMessageEvenWhenWaitingForSyncReply in order for them to be dispatched in order with synchronous messages.

Affects case where wait happens when RemoteRenderingBackend is created.

[Kimmo Kinnunen]

Created attachment 420820 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/74738277>

[Said Abou-Hallawa]

Comment on attachment 420820 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420820&action=review

> Source/WebKit/ChangeLog:22
> +        If GPU process is waiting for a sync reply when the sequence up

What are the synchronous messages which GPUP sends and waits for their replies?

[Kimmo Kinnunen]

(In reply to Said Abou-Hallawa from comment #3)
> > Source/WebKit/ChangeLog:22
> > +        If GPU process is waiting for a sync reply when the sequence up
> 
> What are the synchronous messages which GPUP sends and waits for their
> replies?

I don't know enough of the codepaths to figure that out.
I cannot see any in GPUProcess/ or Shared/, but it does not mean they don't happen today or in the future..

[Kimmo Kinnunen]

Created attachment 423153 [details]
rebase

[EWS]

Committed r274413: <https://commits.webkit.org/r274413>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423153 [details].