Bug 222096 - Small conformance issues in web-animations/interfaces/Animation/commitStyles.html
Summary: Small conformance issues in web-animations/interfaces/Animation/commitStyles....
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar, WPTImpact
Depends on: 246913 23924 242007 246008 246011 246914
Blocks:
  Show dependency treegraph
 
Reported: 2021-02-18 01:15 PST by Philip Jägenstedt
Modified: 2022-10-25 01:46 PDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Philip Jägenstedt 2021-02-18 01:15:31 PST
Safari and WebKitGTK have some failures in WPT's web-animations/interfaces/Animation/commitStyles.html:
https://wpt.fyi/results/web-animations/interfaces/Animation/commitStyles.html?run_id=5684229927075840&run_id=5715930678034432&run_id=5099062846029824&run_id=5655709666508800

Over in https://github.com/mdn/browser-compat-data/pull/7233#issuecomment-780920038, Brian Birtles looked over the failures and very helpfully broke them down. The conclusion was the issues don't look very severe, but I'm filing this issue so that his analysis can be found from this bug tracker in case someone looks into it. Inlining the comment here too for searchability:

- Incorrect handling of logical properties -- fairly minor?
- Incorrect handling of custom variables -- probably due to not implementing registered properties -- Firefox also fails this for that reason
- Incorrect unit conversion / serialization for em units, line-height, transforms -- only an issue if you are actually reading back the value from style
- Incorrect handling of animations in a stack of composited animations -- pretty minor case
- Incorrect handling of redundant changes with regards to mutation observers -- edge case
Comment 1 Antoine Quint 2021-02-18 02:37:50 PST
Thanks for raising this Philip. For composited animations, we simply don't support them (yet). The other issues are known as well, but a bug tracking this test is welcome.
Comment 2 Radar WebKit Bug Importer 2021-02-25 01:16:14 PST
<rdar://problem/74735215>
Comment 3 Antoine Quint 2022-06-26 10:41:50 PDT
"Incorrect handling of custom variables" will be fixed in bug 242007.
Comment 4 Antoine Quint 2022-10-25 01:46:15 PDT
There is only one remaining failing subtest, which is tracked by bug 246913, but it will require some doing since we need do implement the mix() function from CSS Values Level 4.