Bug 222089 - Return correct target for App Highlight menus.
Summary: Return correct target for App Highlight menus.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Megan Gardner
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-17 19:25 PST by Megan Gardner
Modified: 2021-02-18 00:00 PST (History)
2 users (show)

See Also:

Attachments
Patch (1.39 KB, patch)
2021-02-17 19:26 PST, Megan Gardner 		no flags Details | Formatted Diff | Diff
Patch (1.41 KB, patch)
2021-02-17 19:43 PST, Megan Gardner 		no flags Details | Formatted Diff | Diff
Patch for landing (1.41 KB, patch)
2021-02-17 20:42 PST, Megan Gardner 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Megan Gardner 2021-02-17 19:25:34 PST 
Return correct target for App Highlight menus.
Comment 1 Megan Gardner 2021-02-17 19:26:20 PST 
Created attachment 420784 [details]
Patch
Comment 2 Tim Horton 2021-02-17 19:35:06 PST 
Comment on attachment 420784 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420784&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:3699
> +    if (sel_isEqual(action, @selector(createHighlightInCurrentGroupWithRange:)) || sel_isEqual(action, @selector(createHighlightInNewGroupWithRange:)))

You can just use == (see above, or see the sel_isEqual docs)
Comment 3 Megan Gardner 2021-02-17 19:43:52 PST 
Created attachment 420785 [details]
Patch
Comment 4 Megan Gardner 2021-02-17 20:42:50 PST 
Created attachment 420793 [details]
Patch for landing
Comment 5 EWS 2021-02-17 23:59:29 PST 
Committed r273066: <https://commits.webkit.org/r273066>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 420793 [details].
Comment 6 Radar WebKit Bug Importer 2021-02-18 00:00:25 PST 
<rdar://problem/74467567>